From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: emacs-26 8f18d12: Improve documentation of decoding into a unibyte buffer Date: Wed, 29 May 2019 22:09:46 +0300 Message-ID: <83k1e9xekl.fsf@gnu.org> References: <20190525191039.14136.23307@vcs0.savannah.gnu.org> <20190525191040.CCD6C207F5@vcs0.savannah.gnu.org> <83v9xv2649.fsf@gnu.org> <83imtv1fbf.fsf@gnu.org> <7F0B61E6-C0CA-449B-B432-095569589168@gnu.org> <83y32qzk9b.fsf@gnu.org> <83pno2za3d.fsf@gnu.org> <83blzmyo5h.fsf@gnu.org> <83muj5xgw9.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="140347"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed May 29 21:10:49 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hW3yL-000aO9-4L for ged-emacs-devel@m.gmane.org; Wed, 29 May 2019 21:10:49 +0200 Original-Received: from localhost ([127.0.0.1]:59402 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hW3yJ-0005p5-QQ for ged-emacs-devel@m.gmane.org; Wed, 29 May 2019 15:10:47 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:39667) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hW3xC-0005nS-1u for emacs-devel@gnu.org; Wed, 29 May 2019 15:09:38 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:56824) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hW3xB-0003pq-Ot; Wed, 29 May 2019 15:09:37 -0400 Original-Received: from [176.228.60.248] (port=3333 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hW3xB-0003Wn-6K; Wed, 29 May 2019 15:09:37 -0400 In-reply-to: (message from Stefan Monnier on Wed, 29 May 2019 14:58:57 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:237161 Archived-At: > From: Stefan Monnier > Cc: emacs-devel@gnu.org > Date: Wed, 29 May 2019 14:58:57 -0400 > > > > I don't think there was much to discuss about it. > > Unilaterally. > > Yes, it's was a clear and simple bug-fix, AFAIK. We were in the middle of discussing what should be done, so fairness would have it that a patch should be proposed, not pushed. Or so I thought, turns out naïvely. > > I have nothing against you making these changes locally to catch > > bugs. I sometimes do similar things in my locale version of the code. > > Yes, and this experience showed me that it's a good practice to follow > (I don't mean "adding checks" but "align unibyte/multibyte with > encoded/decoded"). > > BTW, I think we should add such checks in `master` (but make them > conditional on a variable like > `check-encoding/decoding-strictly-for-debugging-purposes` which would > of course default to nil). I'm okay with enabling such checks in an Emacs configured with '--enable-checking', but not in the production version. The main purpose of a released Emacs is not to expose bugs, it's to allow users do whatever they need to do in Emacs, even if it means tolerating some bugs.