From: Eli Zaretskii <eliz@gnu.org>
To: Damien Cassou <damien@cassou.me>
Cc: magnus.henoch@gmail.com, tzz@lifelogs.com, npostavs@gmail.com,
iku.iwasa@gmail.com, camalot@picnicpark.org,
gaby.launay@tutanota.com, 36052@debbugs.gnu.org,
nicolas@petton.fr
Subject: bug#36052: 26.2.50; [PATCH] Improve auth-source-pass
Date: Sat, 08 Jun 2019 19:02:54 +0300 [thread overview]
Message-ID: <83k1dwnjyp.fsf@gnu.org> (raw)
In-Reply-To: <87sgskhydy.fsf@cassou.me> (message from Damien Cassou on Sat, 08 Jun 2019 17:47:53 +0200)
> From: Damien Cassou <damien@cassou.me>
> Date: Sat, 08 Jun 2019 17:47:53 +0200
> Cc: Magnus Henoch <magnus.henoch@gmail.com>, Nicolas Petton <nicolas@petton.fr>,
> Iku Iwasa <iku.iwasa@gmail.com>, Keith Amidon <camalot@picnicpark.org>,
> galaunay <gaby.launay@tutanota.com>, 36052@debbugs.gnu.org,
> Ted Zlatanov <tzz@lifelogs.com>
>
> +(defcustom auth-source-pass-filename "~/.password-store"
> + "Path to the password-store folder."
> + :type 'directory)
Please add/update a :version tag to any defcustom that you introduce
or modify. This is the basis for a "C-h v" and a few other features
that report on options introduced/changed in a certain Emacs version.
Also, GNU Coding Standards frown on calling "path" anything that is
not colon-separated PATH-style list of directories.
> >From d46e8dd1bbc3a1c7ac6506e3e6cfe3d87e57e99e Mon Sep 17 00:00:00 2001
> From: galaunay <gaby.launay@tutanota.com>
> Date: Sun, 13 Jan 2019 21:30:53 +0000
> Subject: [PATCH 04/12] Add auth-source-pass-path option
This patch was included twice, it seems.
> +(defun auth-source-pass--get-attr (key entry-data)
> + "Return the value associated to KEY in data from an already parsed entry.
We prefer that the first line of a function's doc references all of
the arguments. In this case, I suggest to reword as follows:
Return value associated with KEY in an ENTRY-DATA.
What ENTRY-DATA is is explained in the very next line"
> +ENTRY-DATA is the data from a parsed password-store entry.
So you don't need to repeat that in the first line.
> --- a/etc/NEWS
> +++ b/etc/NEWS
> @@ -1485,6 +1485,21 @@ the new variable 'buffer-auto-revert-by-notification' to a non-nil
> value. Auto Revert mode can use this information to avoid polling the
> buffer periodically when 'auto-revert-avoid-polling' is non-nil.
>
> +** auth-source-pass
> +
> +*** New customizable variable 'auth-source-pass-filename'.
> +Allows setting the path to the password-store, defaults to
> +~/.password-store.
> +
> +*** New customizable variable 'auth-source-pass-port-separator'.
> +Specifies separator between host and port, defaults to colon ":".
> +
> +*** Minimize the number of decryptions during password lookup.
> +This makes the package usable with physical tokens requiring touching
> +a sensor for every decryption.
> +
> +*** 'auth-source-pass-get' is now autoloaded.
Do these changes warrant changes in auth.texi manual?
Thanks for working on this.
next prev parent reply other threads:[~2019-06-08 16:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-02 9:11 bug#36052: 26.2.50; [PATCH] Improve auth-source-pass Damien Cassou
2019-06-07 0:43 ` Noam Postavsky
2019-06-08 15:47 ` Damien Cassou
2019-06-08 16:02 ` Eli Zaretskii [this message]
2019-06-08 22:38 ` Noam Postavsky
2019-06-13 19:59 ` Damien Cassou
2019-06-13 21:23 ` Noam Postavsky
2019-06-14 7:10 ` Damien Cassou
2019-06-14 7:47 ` Eli Zaretskii
2019-06-14 16:16 ` Damien Cassou
2019-06-22 9:02 ` Eli Zaretskii
2019-06-24 7:26 ` Damien Cassou
2019-06-24 14:33 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83k1dwnjyp.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=36052@debbugs.gnu.org \
--cc=camalot@picnicpark.org \
--cc=damien@cassou.me \
--cc=gaby.launay@tutanota.com \
--cc=iku.iwasa@gmail.com \
--cc=magnus.henoch@gmail.com \
--cc=nicolas@petton.fr \
--cc=npostavs@gmail.com \
--cc=tzz@lifelogs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.