From: Eli Zaretskii <eliz@gnu.org>
To: Pip Cet <pipcet@gmail.com>
Cc: 36190@debbugs.gnu.org
Subject: bug#36190: 27.0.50; `put-text-property' etc. with buffer argument calls current buffer's `after-change-functions'
Date: Fri, 14 Jun 2019 10:41:45 +0300 [thread overview]
Message-ID: <83k1doy5om.fsf@gnu.org> (raw)
In-Reply-To: <CAOqdjBemrLfvNK_48wvLuP0hQH90p7LryrpiHjQ77z8SNMSLNQ@mail.gmail.com> (message from Pip Cet on Thu, 13 Jun 2019 21:37:40 +0000)
> From: Pip Cet <pipcet@gmail.com>
> Date: Thu, 13 Jun 2019 21:37:40 +0000
> Cc: 36190@debbugs.gnu.org
>
> +/* Signal a change immediately after it happens.
> + BUFFER is the buffer in which the change happened.
> + CHARPOS is the character position of the start of the changed text.
> + LENDEL is the number of characters of the text before the change.
> + (Not the whole buffer; just the part that was changed.)
> + LENINS is the number of characters in that part of the text
> + after the change. */
I would just say "Like signal_after_change, but ..." and describe only
the BUFFER argument.
> +void
> +signal_after_change_in_buffer (struct buffer *buffer, ptrdiff_t charpos, ptrdiff_t lendel, ptrdiff_t lenins)
> +{
> + ptrdiff_t count = SPECPDL_INDEX ();
> +
> + record_unwind_current_buffer ();
> + set_buffer_internal (buffer);
> + signal_after_change (charpos, lendel, lenins);
> + unbind_to (count, Qnil);
> +}
I still think we should explicitly detect the current_buffer case here
and if so, avoid the calls to everything else except
signal_after_change itself.
But I indeed like this patch better, although the concerns over the
performance hit are still present. Thanks.
next prev parent reply other threads:[~2019-06-14 7:41 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-13 13:48 bug#36190: 27.0.50; `put-text-property' etc. with buffer argument calls current buffer's `after-change-functions' Pip Cet
2019-06-13 16:36 ` Eli Zaretskii
2019-06-13 18:48 ` Pip Cet
2019-06-13 19:05 ` Eli Zaretskii
2019-06-13 19:27 ` Eli Zaretskii
2019-06-13 19:42 ` Pip Cet
2019-06-13 20:01 ` Eli Zaretskii
2019-06-13 20:57 ` Pip Cet
2019-06-13 21:37 ` Pip Cet
2019-06-14 7:41 ` Eli Zaretskii [this message]
2019-06-14 11:14 ` Pip Cet
2019-06-14 12:10 ` Eli Zaretskii
2019-06-15 15:14 ` Pip Cet
2019-06-15 15:23 ` Eli Zaretskii
2019-06-15 19:27 ` Pip Cet
2019-07-06 8:08 ` Eli Zaretskii
2019-07-06 15:27 ` Pip Cet
2019-07-06 16:22 ` Eli Zaretskii
2019-06-14 7:36 ` Eli Zaretskii
2019-06-17 11:38 ` Pip Cet
2019-06-17 15:59 ` Eli Zaretskii
2019-06-18 17:14 ` Pip Cet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83k1doy5om.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=36190@debbugs.gnu.org \
--cc=pipcet@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.