From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: kbrown@cornell.edu, emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 74a5a33: Support native image transforms on MS-Windows
Date: Sun, 30 Jun 2019 17:21:58 +0300 [thread overview]
Message-ID: <83k1d3f915.fsf@gnu.org> (raw)
In-Reply-To: <6a3dbb42-d2ca-82ea-0cfb-0139e0a70f6e@cs.ucla.edu> (message from Paul Eggert on Sat, 29 Jun 2019 21:08:46 -0700)
> Cc: kbrown@cornell.edu, emacs-devel@gnu.org
> From: Paul Eggert <eggert@cs.ucla.edu>
> Date: Sat, 29 Jun 2019 21:08:46 -0700
>
> Eli Zaretskii wrote:
> > divide_double part obfuscates the code for no good reason.
>
> I'm sure we can clear it up. It replaces the check against FLT_MIN, which to my
> mind was even more obscure as there are no 'float' values in sight.
I mean that an explicit division together with a test is more clear
than a call to a function that one needs to look up.
> What is the failure scenario here? Is it not floating-point division by zero?
Yes. But in one of the branches that is extremely unlikely, since the
denominator comes from the size of an image that we loaded.
prev parent reply other threads:[~2019-06-30 14:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190629115503.5317.97999@vcs0.savannah.gnu.org>
[not found] ` <20190629115506.BDED9208EA@vcs0.savannah.gnu.org>
2019-06-29 19:21 ` [Emacs-diffs] master 74a5a33: Support native image transforms on MS-Windows Ken Brown
2019-06-30 0:00 ` Paul Eggert
2019-06-30 2:39 ` Eli Zaretskii
2019-06-30 4:08 ` Paul Eggert
2019-06-30 14:21 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83k1d3f915.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=kbrown@cornell.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.