From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: so-long tests
Date: Sat, 13 Jul 2019 11:19:34 +0300
Message-ID: <83k1cm1h49.fsf@gnu.org>
References: <83sgra1jn6.fsf@gnu.org>
 <1046d298-c0bc-a69f-39a7-011aa993c9da@orcon.net.nz>
Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226";
	logging-data="126019"; mail-complaints-to="usenet@blaine.gmane.org"
Cc: emacs-devel@gnu.org
To: Phil Sainty <psainty@orcon.net.nz>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jul 13 10:19:47 2019
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.89)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1hmDFy-000We3-7o
	for ged-emacs-devel@m.gmane.org; Sat, 13 Jul 2019 10:19:46 +0200
Original-Received: from localhost ([::1]:54146 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.86_2)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1hmDFw-0006bQ-Cj
	for ged-emacs-devel@m.gmane.org; Sat, 13 Jul 2019 04:19:44 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34734)
 by lists.gnu.org with esmtp (Exim 4.86_2)
 (envelope-from <eliz@gnu.org>) id 1hmDFt-0006Zs-11
 for emacs-devel@gnu.org; Sat, 13 Jul 2019 04:19:41 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:59256)
 by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
 id 1hmDFs-0005L7-6S; Sat, 13 Jul 2019 04:19:40 -0400
Original-Received: from [176.228.60.248] (port=2001 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1hmDFr-0000Bg-Io; Sat, 13 Jul 2019 04:19:40 -0400
In-reply-to: <1046d298-c0bc-a69f-39a7-011aa993c9da@orcon.net.nz> (message from
 Phil Sainty on Sat, 13 Jul 2019 20:08:35 +1200)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: "Emacs-devel" <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.devel:238545
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/238545>

> From: Phil Sainty <psainty@orcon.net.nz>
> Date: Sat, 13 Jul 2019 20:08:35 +1200
> Cc: emacs-devel@gnu.org
> 
> > I think the tests for the new package should be moved to be under
> > test/lisp/, because we generally mirror under test/ the source tree
> > structure.
> 
> I've done it this way based on the documentation in
> test/file-organization.org:
> 
> > Tests should normally reside in a file with ~-tests.el~ added to the
> > base-name of the tested source file; hence ~ert.el~ is tested in
> > ~ert-tests.el~, and ~pcase.el~ is tested in ~pcase-tests.el~.  As an
> > exception, tests for a single feature may be placed into multiple
> > files of any name which are themselves placed in a directory named
> > after the feature with ~-tests~ appended, such as
> > ~/test/lisp/emacs-lisp/eieio-tests~
> 
> Hence test/lisp/so-long-tests/*
> 
> So I *think* that's correct as-is?

Why do we need the exception in this case?  Exceptions should be
reserved for exceptional cases.