From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#31946: 27.0.50; The NSM should warn about more TLS problems Date: Mon, 26 Aug 2019 19:07:13 +0300 Message-ID: <83k1azgbbi.fsf@gnu.org> References: <87h8647de5.fsf@gnus.org> <86tva4dq8h.fsf@gmail.com> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="206163"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 31946@debbugs.gnu.org To: Andy Moreton Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Aug 26 18:10:03 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i2HZD-000rVQ-3S for geb-bug-gnu-emacs@m.gmane.org; Mon, 26 Aug 2019 18:10:03 +0200 Original-Received: from localhost ([::1]:55310 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i2HZB-0006RG-Ov for geb-bug-gnu-emacs@m.gmane.org; Mon, 26 Aug 2019 12:10:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35875) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i2HXH-0004nA-By for bug-gnu-emacs@gnu.org; Mon, 26 Aug 2019 12:08:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i2HXG-0004xY-5r for bug-gnu-emacs@gnu.org; Mon, 26 Aug 2019 12:08:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38304) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i2HXG-0004xQ-23 for bug-gnu-emacs@gnu.org; Mon, 26 Aug 2019 12:08:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1i2HXF-00040f-Ql for bug-gnu-emacs@gnu.org; Mon, 26 Aug 2019 12:08:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Aug 2019 16:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31946 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: security fixed Original-Received: via spool by 31946-submit@debbugs.gnu.org id=B31946.156683564215336 (code B ref 31946); Mon, 26 Aug 2019 16:08:01 +0000 Original-Received: (at 31946) by debbugs.gnu.org; 26 Aug 2019 16:07:22 +0000 Original-Received: from localhost ([127.0.0.1]:47125 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i2HWb-0003zI-UA for submit@debbugs.gnu.org; Mon, 26 Aug 2019 12:07:22 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:55457) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i2HWa-0003z1-7Q for 31946@debbugs.gnu.org; Mon, 26 Aug 2019 12:07:20 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:42749) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1i2HWT-0004eq-SO; Mon, 26 Aug 2019 12:07:13 -0400 Original-Received: from [176.228.60.248] (port=2892 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1i2HWS-0002Ch-BK; Mon, 26 Aug 2019 12:07:12 -0400 In-reply-to: <86tva4dq8h.fsf@gmail.com> (message from Andy Moreton on Mon, 26 Aug 2019 14:13:18 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:165908 Archived-At: > From: Andy Moreton > Date: Mon, 26 Aug 2019 14:13:18 +0100 > > On Mon 26 Aug 2019, Lars Ingebrigtsen wrote: > > > The netsec branch has now been merged into the trunk and I'm closing > > this bug report. > > After this merge, the network tests fail on 64 bit windows (MSYS2), and > using any network functionality results in crashes. > > >From emacs --no-desktop under gdb, running list-packages pops upo the > NSM "Certificate information" window and asks "Continue comnecting?". > Any of the asnwer for this question result in a crash. > > warning: HEAP[emacs.exe]: > warning: Invalid address specified to RtlFreeHeap( 0000000002720000, 0000000006037150 ) > > Thread 1 received signal SIGTRAP, Trace/breakpoint trap. > 0x00007ff9199863b7 in ntdll!RtlpNtMakeTemporaryKey () from C:\WINDOWS\SYSTEM32\ntdll.dll > (gdb) #0 0x00007ff9199863b7 in ntdll!RtlpNtMakeTemporaryKey () from C:\WINDOWS\SYSTEM32\ntdll.dll > No symbol table info available. > #1 0x00007ff919941467 in ntdll!memset () from C:\WINDOWS\SYSTEM32\ntdll.dll > No symbol table info available. > #2 0x00007ff919985290 in ntdll!RtlpNtMakeTemporaryKey () from C:\WINDOWS\SYSTEM32\ntdll.dll > No symbol table info available. > #3 0x00007ff9199356b8 in ntdll!memset () from C:\WINDOWS\SYSTEM32\ntdll.dll > No symbol table info available. > #4 0x00007ff9198c07a0 in ntdll!RtlGetCurrentServiceSessionId () from C:\WINDOWS\SYSTEM32\ntdll.dll > No symbol table info available. > #5 0x00007ff9198bfba1 in ntdll!RtlFreeHeap () from C:\WINDOWS\SYSTEM32\ntdll.dll > No symbol table info available. > #6 0x000000040029e7aa in free_after_dump (ptr=0x6037150) at C:/emacs/git/emacs/master/src/w32heap.c:504 > No locals. > #7 0x000000040018b7f4 in xfree (block=0x6037150) at C:/emacs/git/emacs/master/src/alloc.c:748 > No locals. > #8 0x0000000400227bb0 in Fgnutls_format_certificate (cert=XIL(0xd97ad24)) at C:/emacs/git/emacs/master/src/gnutls.c:1616 That's because any memory allocated by GnuTLS cannot be freed by Emacs via 'free' or 'xfree', it needs to be freed by calling 'gnutls_free' (the GnuTLS manual clearly says that, btw). That crashes, because on Windows we use our own implementation of 'free', which uses a different heap. Please try the latest master, I tried to fix that. Also, please tell which tests specifically crashed/failed for you, I'd like to run them here. Thanks.