From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Tab bar tabs landed on master Date: Sun, 12 Jan 2020 05:28:50 +0200 Message-ID: <83k15x73pp.fsf@gnu.org> References: <8736gci5jn.fsf@mail.linkov.net> <83muej8a0f.fsf@gnu.org> <87zhijqfys.fsf@mail.linkov.net> <834l0r84at.fsf@gnu.org> <87bluyj51u.fsf@mail.linkov.net> <838spz45zc.fsf@gnu.org> <87a7aex2v9.fsf@mail.linkov.net> <83k19h3it3.fsf@gnu.org> <87sgo4tlic.fsf@mail.linkov.net> <83blusz7ec.fsf@gnu.org> <83y2xuur76.fsf@gnu.org> <871rvliwtu.fsf@mail.linkov.net> <83v9sxu4mc.fsf@gnu.org> <87sgkllhyl.fsf@mail.linkov.net> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="114426"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jan 12 04:32:53 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iqTwH-0003ao-Gl for ged-emacs-devel@m.gmane-mx.org; Sun, 12 Jan 2020 04:29:21 +0100 Original-Received: from localhost ([::1]:34836 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iqTwG-0000yT-CQ for ged-emacs-devel@m.gmane-mx.org; Sat, 11 Jan 2020 22:29:20 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:32827) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iqTvk-0000Yj-C7 for emacs-devel@gnu.org; Sat, 11 Jan 2020 22:28:49 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:57818) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iqTvj-0005gD-18; Sat, 11 Jan 2020 22:28:47 -0500 Original-Received: from [176.228.60.248] (port=4635 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iqTvh-0003C3-Nl; Sat, 11 Jan 2020 22:28:46 -0500 In-reply-to: <87sgkllhyl.fsf@mail.linkov.net> (message from Juri Linkov on Sun, 12 Jan 2020 01:57:22 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:244208 Archived-At: > From: Juri Linkov > Cc: emacs-devel@gnu.org > Date: Sun, 12 Jan 2020 01:57:22 +0200 > > > I think this is a sign that the up_modifier needs to be reset from the > > event modifiers inside tty_handle_tab_bar_click, as I envisioned. Can > > you try that? > > Finally I got a chance to test this on a GPM-capable console > (there was a problem that the key on my keyboard is broken > that is not a problem on X where it's remapped to , > but on the console only the key has an alternative , > not , and using such replacements as 'ESC x next-line RET' > is too cumbersome, ISTR there was some support for key remapping, > and I used it long ago on console, but already forgot all details, > so I had to find a keyboard with a functional key.) > > Anyway, here is the tested patch that indeed needed to reset up_modifier. > Sorry for the delay. Thanks, please push this to the emacs-27 branch.