From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#25496: 25.1.91; INSIDE_EMACS env variable is not set in eshell Date: Fri, 03 Apr 2020 15:17:30 +0300 Message-ID: <83k12wwyp1.fsf@gnu.org> References: <87zhc0huyn.fsf@gmail.com> <874ku6yeu4.fsf@gmail.com> <87sghqipkx.fsf@gmail.com> <87wo71ipri.fsf@gmail.com> <87o8sdigl3.fsf@gmail.com> Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="79249"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 25496@debbugs.gnu.org, federicotedin@gmail.com To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Apr 03 14:18:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jKLH0-000KTv-J9 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 03 Apr 2020 14:18:10 +0200 Original-Received: from localhost ([::1]:54586 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jKLGz-0004xJ-D2 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 03 Apr 2020 08:18:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52187) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jKLGt-0004xB-Ce for bug-gnu-emacs@gnu.org; Fri, 03 Apr 2020 08:18:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jKLGs-0000WX-BR for bug-gnu-emacs@gnu.org; Fri, 03 Apr 2020 08:18:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58025) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jKLGs-0000WP-8j for bug-gnu-emacs@gnu.org; Fri, 03 Apr 2020 08:18:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jKLGs-0004m8-4O for bug-gnu-emacs@gnu.org; Fri, 03 Apr 2020 08:18:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 Apr 2020 12:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25496 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch Original-Received: via spool by 25496-submit@debbugs.gnu.org id=B25496.158591627318325 (code B ref 25496); Fri, 03 Apr 2020 12:18:02 +0000 Original-Received: (at 25496) by debbugs.gnu.org; 3 Apr 2020 12:17:53 +0000 Original-Received: from localhost ([127.0.0.1]:41338 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jKLGi-0004lU-U9 for submit@debbugs.gnu.org; Fri, 03 Apr 2020 08:17:53 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:37055) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jKLGh-0004ky-Be for 25496@debbugs.gnu.org; Fri, 03 Apr 2020 08:17:51 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:46810) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1jKLGc-0000R0-8i; Fri, 03 Apr 2020 08:17:46 -0400 Original-Received: from [176.228.60.248] (port=2649 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jKLGb-0003zc-Ns; Fri, 03 Apr 2020 08:17:46 -0400 In-Reply-To: <87o8sdigl3.fsf@gmail.com> (message from Noam Postavsky on Mon, 30 Mar 2020 19:11:04 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:177984 Archived-At: > From: Noam Postavsky > Date: Mon, 30 Mar 2020 19:11:04 -0400 > Cc: 25496@debbugs.gnu.org > > > +If the value is a string, the value for the variable with that name in > > +the current environment will be returned. If no variable with that > > +name exists in the environment, but if a symbol with that same name > > +exists and has a value bound to it, then that value will be used. You > > +can prioritize symbol values over environment values by setting > > +`eshell-prefer-lisp-variables' to t. > > + > > +If the value is a symbol, the value bound to that symbol will be used. > > Much better, thanks. Would it be possible to reword this so that passive tense is used less frequently? E.g., instead of "the variable with that name in the current environment will be returned", how about "return the variable with that name in the current environment"? And similarly with the rest of the doc string. Thanks.