From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: master 8dcb19f 4/4: Add a unit test testing interaction between threads and processes. Date: Sat, 23 Jan 2021 21:49:18 +0200 Message-ID: <83k0s34eo1.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31442"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Philipp Stephani , emacs-devel@gnu.org To: p.stephani2@gmail.com (Philipp Stephani) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jan 23 20:50:48 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l3Ovo-00085n-69 for ged-emacs-devel@m.gmane-mx.org; Sat, 23 Jan 2021 20:50:48 +0100 Original-Received: from localhost ([::1]:48222 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l3Ovn-0005UX-7F for ged-emacs-devel@m.gmane-mx.org; Sat, 23 Jan 2021 14:50:47 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60834) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l3OuW-00051y-LG for emacs-devel@gnu.org; Sat, 23 Jan 2021 14:49:29 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:47781) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l3OuU-0000y0-FL; Sat, 23 Jan 2021 14:49:28 -0500 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1802 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1l3OuS-0000f4-Cs; Sat, 23 Jan 2021 14:49:26 -0500 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:263313 Archived-At: This additional test fails on MS-Windows: Test process-tests/multiple-threads-waiting backtrace: signal(ert-test-failed (((should (eql (process-exit-status process) ert-fail(((should (eql (process-exit-status process) 0)) :form (eql (if (unwind-protect (setq value-344 (apply fn-342 args-343)) (setq f (let (form-description-346) (if (unwind-protect (setq value-344 (app (let ((value-344 'ert-form-evaluation-aborted-345)) (let (form-descr (let* ((fn-342 #'eql) (args-343 (condition-case err (let ((signal-ho (while (and (consp --cl-var--) (consp --cl-var--)) (progn (setq proc (let ((--cl-var-- processes) (process nil) (--cl-var-- threads) (thr (let ((threads nil) (cat (executable-find "cat"))) (let ((value-335 (unwind-protect (let ((threads nil) (cat (executable-find "cat"))) ( (let ((processes nil)) (unwind-protect (let ((threads nil) (cat (exe (progn (let ((processes nil)) (unwind-protect (let ((threads nil) (c (unwind-protect (progn (let ((processes nil)) (unwind-protect (let ( (let* ((-with-timeout-timer- (run-with-timer 60 nil #'(lambda nil (t (catch 'timeout (let* ((-with-timeout-timer- (run-with-timer 60 nil (let ((-with-timeout-value- (catch 'timeout (let* ((-with-timeout-ti (closure (t) nil (let* ((fn-330 #'fboundp) (args-331 (condition-case ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name process-tests/multiple-threads-waitin ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m ert-run-tests((not (tag :unstable)) #f(compiled-function (event-type ert-run-tests-batch((not (tag :unstable))) ert-run-tests-batch-and-exit((not (tag :unstable))) eval((ert-run-tests-batch-and-exit '(not (tag :unstable))) t) command-line-1(("-L" ";." "-l" "ert" "-l" "src/process-tests.el" "-- command-line() normal-top-level() Test process-tests/multiple-threads-waiting condition: (ert-test-failed ((should (eql (process-exit-status process) 0)) :form (eql 1 0) :value nil)) FAILED 21/26 process-tests/multiple-threads-waiting (8.859375 sec) I did verify that process-send-eof does cause 'cat' to exit, so the problem is likely in some issue related to threads and what the test assumes regarding what should happen here.