From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#51605: Fwd: [PATCH] Update themes to support mode-line Date: Sun, 05 Dec 2021 20:38:23 +0200 Message-ID: <83k0gi3nj4.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18066"; mail-complaints-to="usenet@ciao.gmane.io" Cc: paaguti@gmail.com, 51605@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 05 19:39:22 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mtwPw-0004RH-1T for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 05 Dec 2021 19:39:20 +0100 Original-Received: from localhost ([::1]:56470 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mtwPu-0007ia-Cg for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 05 Dec 2021 13:39:18 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:45100) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mtwPe-0007iQ-4f for bug-gnu-emacs@gnu.org; Sun, 05 Dec 2021 13:39:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47883) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mtwPd-0004dT-TH for bug-gnu-emacs@gnu.org; Sun, 05 Dec 2021 13:39:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mtwPd-0001OP-Ra for bug-gnu-emacs@gnu.org; Sun, 05 Dec 2021 13:39:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Dec 2021 18:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51605 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51605-submit@debbugs.gnu.org id=B51605.16387295165322 (code B ref 51605); Sun, 05 Dec 2021 18:39:01 +0000 Original-Received: (at 51605) by debbugs.gnu.org; 5 Dec 2021 18:38:36 +0000 Original-Received: from localhost ([127.0.0.1]:59429 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtwPD-0001Nm-Ol for submit@debbugs.gnu.org; Sun, 05 Dec 2021 13:38:35 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:44268) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtwPC-0001NY-Aa for 51605@debbugs.gnu.org; Sun, 05 Dec 2021 13:38:34 -0500 Original-Received: from [2001:470:142:3::e] (port=46336 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mtwP6-0004a9-Pq; Sun, 05 Dec 2021 13:38:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=oRHJMStxhHDWCZC1M2Ys9VZjpL2MdLQ4a53QD7HVoxw=; b=FIS0DbFzVKyQ cvZJYN4/xLd0Nji11M9jv99cNUOEsSrlcXT9FiHppRC3ZZdzJrD6D17mI7bjX0pPY1C2kuD9FjGXz pYu83qaSg0D3ovMkh6390e2p1bfCVmfUKMsfEfj/fz7reSr1+ewVub8KD1PYY/KjURbStho+7aO9i +sS1OO6KCwqa92dcXFUYNK+LkLh2/l9sLPE2fZ7zYOkaTDqagFHN8x4JQfQpDhi1F4EvEMhFN4he2 PgYW14ahW/H9vc9lgTgOVKJ2YkwrhogZgEMBJXNUvFlIq9tD/px1h3IthUHaJ1hFi8loC37i4Wc0T F9bXGL9Pk05GbOE9MT2N/w==; Original-Received: from [87.69.77.57] (port=1930 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mtwP5-0001s3-Aw; Sun, 05 Dec 2021 13:38:28 -0500 In-Reply-To: (message from Stefan Kangas on Sun, 5 Dec 2021 19:05:36 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:221633 Archived-At: > From: Stefan Kangas > Date: Sun, 5 Dec 2021 19:05:36 +0100 > Cc: Pedro Andres Aranda Gutierrez > > AFAICT, the point of this patch is essentially changing the line-number > face to inherit the fringe face and line-number-current to have the > default foreground (to make the current line more visible). > > I think this makes sense and looks good. I checked, and this seems to > be what VSCode is doing too, so I don't think it's a controversial > design choice. > > So I'd suggest installing the below diff, and then an adapted version of > the proposed patch from Pedro Andres Aranda Gutierrez. Comments? I don't think we should change defaults of the faces because someone prefers to have them look differently. Faces can be easily customized, so people who don't like the defaults can have the faces they like very easily.