From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#54190: 29.0.50; [PATCH] Incorrect/missing documentation for some Eshell "$" syntaxes Date: Fri, 04 Mar 2022 09:16:44 +0200 Message-ID: <83k0dai3vn.fsf@gnu.org> References: <0c3898ff-23ac-51bc-2211-770302d7d00e@gmail.com> <06a184d5-b191-4c63-a851-13d1c8c18eda@gmail.com> <1dfa575b-bf3f-84ca-b7b5-a612ffc57737@gmail.com> <87o82rqqjs.fsf@gnus.org> <1a23eafb-d856-5e31-9d98-03187a896fc8@gmail.com> <83ilsxlsx0.fsf@gnu.org> <797bb243-5397-bb8f-0902-7f96273e913f@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27146"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, 54190@debbugs.gnu.org, monnier@iro.umontreal.ca To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Mar 04 08:19:36 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nQ2Dw-0006vo-4H for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 04 Mar 2022 08:19:36 +0100 Original-Received: from localhost ([::1]:58824 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nQ2Du-0004y6-ST for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 04 Mar 2022 02:19:34 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:58268) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nQ2BS-0002h8-HQ for bug-gnu-emacs@gnu.org; Fri, 04 Mar 2022 02:17:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50540) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nQ2BR-0001mw-Rd for bug-gnu-emacs@gnu.org; Fri, 04 Mar 2022 02:17:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nQ2BR-0004rr-Ng for bug-gnu-emacs@gnu.org; Fri, 04 Mar 2022 02:17:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 04 Mar 2022 07:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54190 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 54190-submit@debbugs.gnu.org id=B54190.164637821718698 (code B ref 54190); Fri, 04 Mar 2022 07:17:01 +0000 Original-Received: (at 54190) by debbugs.gnu.org; 4 Mar 2022 07:16:57 +0000 Original-Received: from localhost ([127.0.0.1]:44437 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nQ2BM-0004rV-Tm for submit@debbugs.gnu.org; Fri, 04 Mar 2022 02:16:57 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:52546) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nQ2BL-0004rI-5F for 54190@debbugs.gnu.org; Fri, 04 Mar 2022 02:16:55 -0500 Original-Received: from [2001:470:142:3::e] (port=41172 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nQ2BD-0001ld-G1; Fri, 04 Mar 2022 02:16:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=S8hJDtZMJBD0nBPTjkTWPHTGo6SvpVG2Xub5aQqgWPU=; b=YYXd+4e4WA8z SpQ2SlTNqnqcMoZ+5mj9wYL/8IC2gUvR+ecBPPua5mCkuzo6GmbYemAQ7g36ztMVMg5vGduM4HKzO Z9NxhSWrCdHgTgf3jNY3nRod4CpYr7/vc7HX2PsKJ9okP/ct1lxJl4BnXBgDOL61++8OSUrbYoAnM ByI68VkdgxK0v8BbSgPRvjO2F4ZEZMmg/PT+6LfKYApuT7yDUOJJgLy/dYVuvjBYdU8lb5Wj+BbfK iBc+UVm0hcuwA70diZT8/+3YUE/LdbNVio1ZpQfSBow0c84eaqIjs74aT5qjc4+n7R8ibIB2PmKTz Xcmujw5iGpcHjZjB0+n2Rw==; Original-Received: from [87.69.77.57] (port=1754 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nQ2BA-0007JG-JN; Fri, 04 Mar 2022 02:16:47 -0500 In-Reply-To: <797bb243-5397-bb8f-0902-7f96273e913f@gmail.com> (message from Jim Porter on Thu, 3 Mar 2022 21:55:41 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:227989 Archived-At: > Cc: larsi@gnus.org, 54190@debbugs.gnu.org, monnier@iro.umontreal.ca > From: Jim Porter > Date: Thu, 3 Mar 2022 21:55:41 -0800 > > After a bit of looking at the `eshell-do-eval' implementation, I > realized that there's a better solution that's very simple. See the > attached patch. It's simple enough that it might be fine for Emacs 28, > but the existing change on the 28 branch is probably a bit safer, since > that change was just a partial revert. I'm not aware of anything that > could be broken by this new patch, but you never know... Thanks, I think this should be installed on master.