From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 5b5608c614: Fix glyph skipping optimization when a tab line is enabled Date: Mon, 18 Apr 2022 10:18:09 +0300 Message-ID: <83k0bmx3ke.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22050"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Apr 18 09:20:51 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ngLgn-0005aY-Vj for ged-emacs-devel@m.gmane-mx.org; Mon, 18 Apr 2022 09:20:50 +0200 Original-Received: from localhost ([::1]:34946 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ngLgm-0004QB-Pb for ged-emacs-devel@m.gmane-mx.org; Mon, 18 Apr 2022 03:20:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50434) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ngLeR-0003gD-05 for emacs-devel@gnu.org; Mon, 18 Apr 2022 03:18:23 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:38472) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ngLeQ-0003md-3Z; Mon, 18 Apr 2022 03:18:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=Subject:To:From:Date:mime-version:in-reply-to: references; bh=A/7Lt6tCmkp86G6x//SagNHQ+gbyeJWNClOSLR5zBc0=; b=gbsk3d2a49+X1b ODbgGD/Ly25Dn6KtZcv19RljA9V7A/B7vMZaC3KV94KcoQ1cpqyA2WS7MXSw8LeG8xJD1i56ds4I8 39o+lBmRUtJI9p8Ek7obw1OCSqhMBrz0pds4w/zatSmIILPmhQWseA4+oSb5GzaYZTANQTKrZqLVb SaqF6zZz+WdJAD6fnBqUvrAn/8XSq+aepVkrbjO3lwebSrDeRDclEFWjL1jBR4ddPD6FyU2mdc8Oo YjI3fN7SOrpd65Oy3YvgXW4pczakW3oYatci0Vtrr4TMXtrk+IUDY4loRMt/ezwgQLFO0JJtZS527 /VnMM2ZL/iWstJ7rPZbA==; Original-Received: from [87.69.77.57] (port=4045 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ngLeP-00066O-FW; Mon, 18 Apr 2022 03:18:21 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:288604 Archived-At: > Author: Po Lu > AuthorDate: Mon Apr 18 13:23:23 2022 +0800 > Commit: Po Lu > CommitDate: Mon Apr 18 13:23:23 2022 +0800 > > Fix glyph skipping optimization when a tab line is enabled > > * src/dispnew.c (update_text_area): Compute vpos of header line > correctly when window has tab line. > > diff --git a/src/dispnew.c b/src/dispnew.c > index 0d95904..3cfe1b8 100644 > --- a/src/dispnew.c > +++ b/src/dispnew.c > @@ -3928,9 +3928,12 @@ update_text_area (struct window *w, struct glyph_row *upd > However, it causes excessive flickering when mouse is moved > across the mode line. Luckily, turning it off for the mode > line doesn't seem to hurt anything. -- cyd. > - But it is still needed for the header line. -- kfs. */ > + But it is still needed for the header line. -- kfs. > + The header line vpos is 1 if a tab line is enabled. (18th > + Apr 2022) */ > || (current_row->mouse_face_p > - && !(current_row->mode_line_p && vpos > 0)) > + && !(current_row->mode_line_p > + && (vpos > w->current_matrix->tab_line_p))) > || current_row->x != desired_row->x) > { > output_cursor_to (w, vpos, 0, desired_row->y, desired_row->x); I'm not sure I understand this change. What exactly is the problem, and how to reproduce it? What if there's no header-line, but there is a tab-line, or vice versa, or both are displayed? And why mentioning the date of the change in the comment? Thanks.