From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#55079: 28.1; kp-decimal not working in vhdl-stutter-mode Date: Sun, 24 Apr 2022 08:18:28 +0300 Message-ID: <83k0bfnjob.fsf@gnu.org> References: <83zgkcninu.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4464"; mail-complaints-to="usenet@ciao.gmane.io" Cc: reto@gnu.org, 55079@debbugs.gnu.org, cyril.arnould@outlook.com To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Apr 24 07:20:16 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1niUfQ-000148-0K for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 24 Apr 2022 07:20:16 +0200 Original-Received: from localhost ([::1]:36752 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1niUfO-0000dX-EO for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 24 Apr 2022 01:20:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55254) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1niUfC-0000d5-3W for bug-gnu-emacs@gnu.org; Sun, 24 Apr 2022 01:20:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35386) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1niUfB-0003Hb-RR for bug-gnu-emacs@gnu.org; Sun, 24 Apr 2022 01:20:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1niUfB-0002dy-NO for bug-gnu-emacs@gnu.org; Sun, 24 Apr 2022 01:20:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 24 Apr 2022 05:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55079 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 55079-submit@debbugs.gnu.org id=B55079.165077754310084 (code B ref 55079); Sun, 24 Apr 2022 05:20:01 +0000 Original-Received: (at 55079) by debbugs.gnu.org; 24 Apr 2022 05:19:03 +0000 Original-Received: from localhost ([127.0.0.1]:57516 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1niUeE-0002ca-OM for submit@debbugs.gnu.org; Sun, 24 Apr 2022 01:19:02 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33662) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1niUeD-0002c5-Sa for 55079@debbugs.gnu.org; Sun, 24 Apr 2022 01:19:02 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:41850) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1niUe6-0003Dt-2p; Sun, 24 Apr 2022 01:18:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=TzYU8eaoR/LQFQFcy11kFq6IbH5QkZaFlK62yDxPRYU=; b=j5jwaw47+Bzm PL9qnD/KBryBVdZ5rhkoEbCi8YayujYijoPcCB1dJbDlU/gJ6w32NTCaocHRImsezRlIS00MLCLf3 a0rKF99C97/bn4mPUUPZIc58c8F37jrTJBFVnjzZC1LxJtPkqtNEDrlimIjG9IpU0wylE1qd5sLZ0 xFkInhA9+UngAAIWDtmcJhWTEB8uXhfVXAW0TkKBp2vTc3PUWpzP+dRgh3Dbzbmq5hGyOI9Jl0+Lt /ISOtfqIQoBTIqth5LakO496+/nv/m/6oR7Bu8JxC58NlsUG1O1XjrCr36r3w6TGrOvaAhMg7+icX HRVQ46sI5nsznaXF/riNjQ==; Original-Received: from [87.69.77.57] (port=3550 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1niUdy-0002n5-Vw; Sun, 24 Apr 2022 01:18:52 -0400 In-Reply-To: (message from Stefan Monnier on Sat, 23 Apr 2022 16:21:42 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:230530 Archived-At: > From: Stefan Monnier > Cc: Reto Zimmermann , Cyril Arnould > , 55079@debbugs.gnu.org > Date: Sat, 23 Apr 2022 16:21:42 -0400 > > [ Adding Reto to the Cc: ] > > > - (cond ((= (preceding-char) vhdl-last-input-event) > > + (cond ((or (and (integerp vhdl-last-input-event) > > + (= (preceding-char) vhdl-last-input-event)) > > + (and (eq vhdl-last-input-event 'kp-decimal) > > + (equal (lookup-key local-function-key-map > > + (vector vhdl-last-input-event)) > > + [?.]) > > + (= (preceding-char) ?.))) > > It does sound pretty kludgey. > How 'bout just replacing `vhdl-last-input-event` with `?\.`, since the > function's name says that this is for period anyway (and the subsequent > `insert-char` inserts a `?\.` regardless of `vhdl-last-input-event`)? Replacing with '?.' where? everywhere? IOW, making the code assume that this command can only be bound to '.'? Or did you mean something else? My feeling of a kludge was not about that, it was about the way I make sure that kp-decimal is remapped to '.'. Do we have some nicer, more general facilities for that?