all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: reto@gnu.org, 55079@debbugs.gnu.org, cyril.arnould@outlook.com
Subject: bug#55079: 28.1; kp-decimal not working in vhdl-stutter-mode
Date: Sun, 24 Apr 2022 08:18:28 +0300	[thread overview]
Message-ID: <83k0bfnjob.fsf@gnu.org> (raw)
In-Reply-To: <jwv7d7f36a1.fsf-monnier+emacs@gnu.org> (message from Stefan Monnier on Sat, 23 Apr 2022 16:21:42 -0400)

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: Reto Zimmermann <reto@gnu.org>, Cyril Arnould
>  <cyril.arnould@outlook.com>,  55079@debbugs.gnu.org
> Date: Sat, 23 Apr 2022 16:21:42 -0400
> 
> [ Adding Reto to the Cc:  ]
> 
> > -      (cond ((= (preceding-char) vhdl-last-input-event)
> > +      (cond ((or (and (integerp vhdl-last-input-event)
> > +                      (= (preceding-char) vhdl-last-input-event))
> > +                 (and (eq vhdl-last-input-event 'kp-decimal)
> > +                      (equal (lookup-key local-function-key-map
> > +                                         (vector vhdl-last-input-event))
> > +                             [?.])
> > +                      (= (preceding-char) ?.)))
> 
> It does sound pretty kludgey.
> How 'bout just replacing `vhdl-last-input-event` with `?\.`, since the
> function's name says that this is for period anyway (and the subsequent
> `insert-char` inserts a `?\.` regardless of `vhdl-last-input-event`)?

Replacing with '?.' where? everywhere?  IOW, making the code assume
that this command can only be bound to '.'?  Or did you mean something
else?

My feeling of a kludge was not about that, it was about the way I make
sure that kp-decimal is remapped to '.'.  Do we have some nicer, more
general facilities for that?





  parent reply	other threads:[~2022-04-24  5:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-23  9:47 bug#55079: 28.1; kp-decimal not working in vhdl-stutter-mode Cyril Arnould
2022-04-23 11:28 ` Eli Zaretskii
2022-04-23 12:57   ` bug#55079: AW: " Cyril Arnould
2022-04-23 13:15     ` Eli Zaretskii
2022-04-23 13:27       ` bug#55079: AW: " Cyril Arnould
2022-04-23 20:21   ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-04-23 22:22     ` bug#55079: AW: " Cyril Arnould
2022-04-24  5:18     ` Eli Zaretskii [this message]
2022-04-24 20:17       ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-04-30  7:12         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83k0bfnjob.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=55079@debbugs.gnu.org \
    --cc=cyril.arnould@outlook.com \
    --cc=monnier@iro.umontreal.ca \
    --cc=reto@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.