From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#56606: Acknowledgement (29.0.50; recent master fails with "creating pipe: too many open files") Date: Tue, 19 Jul 2022 05:38:40 +0300 Message-ID: <83k089omhb.fsf@gnu.org> References: <86ilnwafso.fsf@stephe-leake.org> <86a6989itv.fsf@stephe-leake.org> <8335f0qbvn.fsf@gnu.org> <831qujrjnm.fsf@gnu.org> <86h73ex91m.fsf@stephe-leake.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2879"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 56606-done@debbugs.gnu.org To: Stephen Leake Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jul 19 04:39:09 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oDd8f-0000ZI-My for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 19 Jul 2022 04:39:09 +0200 Original-Received: from localhost ([::1]:42936 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oDd8e-0002jB-JI for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 18 Jul 2022 22:39:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58176) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oDd8Y-0002il-FM for bug-gnu-emacs@gnu.org; Mon, 18 Jul 2022 22:39:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54725) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oDd8Y-0006Vp-7C for bug-gnu-emacs@gnu.org; Mon, 18 Jul 2022 22:39:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oDd8Y-0005F9-3J for bug-gnu-emacs@gnu.org; Mon, 18 Jul 2022 22:39:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Jul 2022 02:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56606 X-GNU-PR-Package: emacs Original-Received: via spool by 56606-done@debbugs.gnu.org id=D56606.165819834020147 (code D ref 56606); Tue, 19 Jul 2022 02:39:02 +0000 Original-Received: (at 56606-done) by debbugs.gnu.org; 19 Jul 2022 02:39:00 +0000 Original-Received: from localhost ([127.0.0.1]:52484 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oDd8V-0005Et-Rg for submit@debbugs.gnu.org; Mon, 18 Jul 2022 22:39:00 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:45238) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oDd8U-0005Eg-5K for 56606-done@debbugs.gnu.org; Mon, 18 Jul 2022 22:38:58 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:54500) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oDd8O-0006Uf-9d; Mon, 18 Jul 2022 22:38:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=oBegYdI+iiY7hiOyWRWv7B52sUE2UVAkiTFJz3J1kwQ=; b=qOcqb6O0Amzj blW6wLzDr9g0Qlzb0m+fNuvTKlxoPQ6kTviYE9eGkG2m89MKMlBdnuDsARNMNSLfFmdtESLpBNnWI Am84IfWSZ8NJul2TKDD+r/UEafdhrQmZYFmuRxmopHUMOENDpfPvI5FK49FGdabYH+val2zdc4iF4 fFUxoywFEQC7zLDjTsejBif8Ffp578DVQIkBO2Yi6UM+7ldBrSNDttn4oG2OOR2AdMGupA6FzOJDk OjkrvBjaVdhJtc6ZxxZneCiBGoYr2GmLE4LInfeYB8XxKp7hUout6UPYe5cDr+tubDPyLw/EczQnC 4mN7Ne31wFImy2tmKrbr6Q==; Original-Received: from [87.69.77.57] (port=3275 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oDd8N-0004Cn-PE; Mon, 18 Jul 2022 22:38:52 -0400 In-Reply-To: <86h73ex91m.fsf@stephe-leake.org> (message from Stephen Leake on Mon, 18 Jul 2022 17:04:05 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:237398 Archived-At: > From: Stephen Leake > Cc: 56606@debbugs.gnu.org > Date: Mon, 18 Jul 2022 17:04:05 -0700 > > Eli Zaretskii writes: > > >> Cc: 56606@debbugs.gnu.org > >> Date: Sun, 17 Jul 2022 13:20:12 +0300 > >> From: Eli Zaretskii > >> > >> > From: Stephen Leake > >> > Date: Sun, 17 Jul 2022 02:42:04 -0700 > >> > > >> > On emacs-devel, Eli said: > >> > > >> > AFAICT, this loop in deactivate_process: > >> > > >> > /* Beware SIGCHLD hereabouts. */ > >> > > >> > for (i = 0; i < PROCESS_OPEN_FDS; i++) > >> > close_process_fd (&p->open_fd[i]); > >> > > >> > doesn't close the last of the 4 descriptors opened by the 2 emacs_pipe > >> > calls in make-pipe-process. It calls 'close' with the right value, > >> > and close returns zero, but the pipe stays open. In Emacs 28, this > >> > same loop successfully closes the descriptor. I don't know why. > >> > > >> > Perhaps bisecting could help. > >> > >> I think commit a81669c could be the culprit. > > > > I hope I fixed this now on master. > > > > Yes, it is fixed, by 637436970f34f860d50f73a514b3bafd0c5cace7. Thanks, I'm therefore closing this bug.