From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#56682: locked narrowing Date: Wed, 17 Aug 2022 19:52:54 +0300 Message-ID: <83k076dd7d.fsf@gnu.org> References: <83edxghqg2.fsf@gnu.org> <325f95fd2bcc0b666b0b@heytings.org> <83edxgfi75.fsf@gnu.org> <5e3c3081-f098-8140-c767-b895c32bf30b@yandex.ru> <835yisffil.fsf@gnu.org> <831qtgff78.fsf@gnu.org> <83zgg4dw4y.fsf@gnu.org> <83r11gdrr4.fsf@gnu.org> <83edxfds7s.fsf@gnu.org> <83r11fc80o.fsf@gnu.org> <83o7wjc6o2.fsf@gnu.org> <83lernc5gu.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28272"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 56682@debbugs.gnu.org, gregory@heytings.org, dgutov@yandex.ru To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 17 18:54:09 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oOMIz-00079x-5h for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 17 Aug 2022 18:54:09 +0200 Original-Received: from localhost ([::1]:34064 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oOMIx-0007Ly-Pd for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 17 Aug 2022 12:54:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52260) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oOMIs-0007LV-0n for bug-gnu-emacs@gnu.org; Wed, 17 Aug 2022 12:54:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34994) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oOMIr-0005mf-OJ for bug-gnu-emacs@gnu.org; Wed, 17 Aug 2022 12:54:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oOMIr-0007qS-JP for bug-gnu-emacs@gnu.org; Wed, 17 Aug 2022 12:54:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 17 Aug 2022 16:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56682 X-GNU-PR-Package: emacs Original-Received: via spool by 56682-submit@debbugs.gnu.org id=B56682.166075519730104 (code B ref 56682); Wed, 17 Aug 2022 16:54:01 +0000 Original-Received: (at 56682) by debbugs.gnu.org; 17 Aug 2022 16:53:17 +0000 Original-Received: from localhost ([127.0.0.1]:52976 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oOMI8-0007pT-Gx for submit@debbugs.gnu.org; Wed, 17 Aug 2022 12:53:16 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:60392) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oOMI3-0007pE-RL for 56682@debbugs.gnu.org; Wed, 17 Aug 2022 12:53:15 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:57456) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oOMHx-0005hj-GF; Wed, 17 Aug 2022 12:53:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=6Ztura/Cjyydvu2UcVnLOIgoTegPtkphWhoUIVmyY68=; b=d1cVehC9QfUL 6nfSbeyeDxxSElv3PYv1knhjfEFLB0e7pZChnscDOr6uSuAeSJniLMG52uQ6sjpyqVhZEMYXxBMCU RMcTEA48x+KHCtGJEujq7pUASeS7PzG00hCPYYHeaB+BvkuYalVfzxK8fW9oj5k6vk6VV65SEMZJr JWOkVp4Q1ZbiZQKgOdLfAfLl905BRBldYDzoifBTTe6Y8/Us+6DKVjykmFYqvxTWpnXocrjIh2frd 8sOLqbKTFshsYsv81SGaGsRIq2Z9SCSO/SkDzVQqlZb2kDuwpkLvXZxx/w5/CHJP8uzYNaXRDVz+v bw3vvbvS2zuqTLhRlgpxCw==; Original-Received: from [87.69.77.57] (port=3739 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oOMHw-0002Cw-Fd; Wed, 17 Aug 2022 12:53:04 -0400 In-Reply-To: (message from Stefan Monnier on Wed, 17 Aug 2022 11:58:32 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:240097 Archived-At: > From: Stefan Monnier > Cc: dgutov@yandex.ru, 56682@debbugs.gnu.org, gregory@heytings.org > Date: Wed, 17 Aug 2022 11:58:32 -0400 > > >> - The problem I already mentioned: the cache seems to be > >> maintained/flushed by the redisplay code, so when the function is > >> called outside of redisplay I don't know if `w->base_line_number/pos` > >> is still valid. > > > > So you are saying that any command which uses vertical-motion or more > > generally any of the move_it_* functions will work incorrectly when > > line numbers are on display? I'm not aware of any such problems. > > No, I'm sure the existing code somehow handles it right. I just don't > know how. I can't see anything in the code of `insert` (say) which > flushes `w->base_line_number` when needed, so there needs to be code > somewhere which flushes it more lazily before using that value. I just > don't know where that code is and which data it uses to flush it. > For this reason I don't know under which condition I can make use of > `w->base_line_number`. Why can't you simply use the same code maybe_produce_line_number uses for that? > [ BTW, another hurdle if that the existing cache is linked to windows, > whereas the actual info requested doesn't care about windows (as long > as we count logical lines rather than screen lines) and would also > make sense in a buffer that's not displayed at all. This should > usually not be a problem for nlinum-mode, tho it could happen > when called from `font-lock-ensure`. ] Why does it matter which line numbers you compute if they are never displayed?