From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#50431: revert-buffer doesn't preserve read-onlyness Date: Thu, 25 Aug 2022 21:55:29 +0300 Message-ID: <83k06w2lwe.fsf@gnu.org> References: <87mtopkj2a.fsf@mail.linkov.net> <87h721oowl.fsf@gnus.org> <86edx5o99p.fsf@mail.linkov.net> <874jy0ju7p.fsf@gnus.org> <86r114qk13.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14504"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, 50431@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 25 20:56:18 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oRI1Z-0003dF-Um for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 25 Aug 2022 20:56:18 +0200 Original-Received: from localhost ([::1]:55200 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oRI1Y-0005Fk-Tg for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 25 Aug 2022 14:56:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58920) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRI1N-0005BM-9F for bug-gnu-emacs@gnu.org; Thu, 25 Aug 2022 14:56:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33313) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oRI1L-0005OF-OB for bug-gnu-emacs@gnu.org; Thu, 25 Aug 2022 14:56:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oRI1K-0000gZ-Gh for bug-gnu-emacs@gnu.org; Thu, 25 Aug 2022 14:56:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Aug 2022 18:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50431 X-GNU-PR-Package: emacs Original-Received: via spool by 50431-submit@debbugs.gnu.org id=B50431.16614537472612 (code B ref 50431); Thu, 25 Aug 2022 18:56:02 +0000 Original-Received: (at 50431) by debbugs.gnu.org; 25 Aug 2022 18:55:47 +0000 Original-Received: from localhost ([127.0.0.1]:51295 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRI14-0000g3-Od for submit@debbugs.gnu.org; Thu, 25 Aug 2022 14:55:47 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:50254) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRI12-0000fr-N3 for 50431@debbugs.gnu.org; Thu, 25 Aug 2022 14:55:45 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:54482) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRI0w-0005Nk-SC; Thu, 25 Aug 2022 14:55:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=JlN2gCToi1sasjK6R8v9l47CPX2Z9Teyk3aP7eIpETE=; b=cYxy1Q+qYHEW WCY9JkLm5ETcvZqljNlJpNmHWamDkNp4o3PvZvyCXn1leLieAnQImNcn0iFHO5UKbu9ZJFqHv3Nn3 lKoz5wlKBYiQ1d/3IHb51qGortsKAbGjO05MJoN3F1Z7jTROKMdEGSMT69JU6p6uX6FGJhL/N63Me 53iRPkToPcIW2qJg6zYEdAq2PnUw7lG3cZlffnHoI3qQWwNWYtaJGMZybtIhRD5jo+ElALxNp/S0E M1GwYcgz/3Wi7dYv1zznNpLdrUvVb7i2c5nfoc/dXJhpE3Bu/5TTAqLdrPX4HSgBCF102WjkVykDI bh3BY113SxfZ4nqkheIgxg==; Original-Received: from [87.69.77.57] (port=3534 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRI0d-0000I7-75; Thu, 25 Aug 2022 14:55:36 -0400 In-Reply-To: <86r114qk13.fsf@mail.linkov.net> (message from Juri Linkov on Thu, 25 Aug 2022 21:02:00 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:240740 Archived-At: > Cc: 50431@debbugs.gnu.org > From: Juri Linkov > Date: Thu, 25 Aug 2022 21:02:00 +0300 > > >> I confirm that now the read-only status is restored, > >> but reverting loses view-mode: > >> > >> C-h C-t -- note "View" on the mode-line; > >> C-x x g -- "View" is lost. > > > > Hm, yes. Reverting a buffer disables all the minor modes? > > Maybe minor modes should be restored after reverting? Only the minor modes that are automatically turned on when visiting the file. Reverting should produce the same effect as killing the buffer and then visiting the file anew, nothing more, nothing less. For that reason, I'm not sure the change that preserves the read-only status across reverts is correct. At the very least, it should be an opt-in feature, IMO.