all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Juri Linkov <juri@linkov.net>
Cc: larsi@gnus.org, 50431@debbugs.gnu.org
Subject: bug#50431: revert-buffer doesn't preserve read-onlyness
Date: Thu, 25 Aug 2022 21:55:29 +0300	[thread overview]
Message-ID: <83k06w2lwe.fsf@gnu.org> (raw)
In-Reply-To: <86r114qk13.fsf@mail.linkov.net> (message from Juri Linkov on Thu, 25 Aug 2022 21:02:00 +0300)

> Cc: 50431@debbugs.gnu.org
> From: Juri Linkov <juri@linkov.net>
> Date: Thu, 25 Aug 2022 21:02:00 +0300
> 
> >> I confirm that now the read-only status is restored,
> >> but reverting loses view-mode:
> >>
> >>   C-h C-t  -- note "View" on the mode-line;
> >>   C-x x g  -- "View" is lost.
> >
> > Hm, yes.  Reverting a buffer disables all the minor modes?
> 
> Maybe minor modes should be restored after reverting?

Only the minor modes that are automatically turned on when visiting
the file.  Reverting should produce the same effect as killing the
buffer and then visiting the file anew, nothing more, nothing less.

For that reason, I'm not sure the change that preserves the read-only
status across reverts is correct.  At the very least, it should be an
opt-in feature, IMO.





  reply	other threads:[~2022-08-25 18:55 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-06 15:03 bug#50431: revert-buffer doesn't preserve read-onlyness Juri Linkov
2021-09-06 16:38 ` Glenn Morris
2021-09-07 15:52   ` Lars Ingebrigtsen
2021-09-09  3:07     ` Richard Stallman
2021-09-09 13:16       ` Lars Ingebrigtsen
2021-09-09 17:27   ` Juri Linkov
2022-08-24 11:35 ` Lars Ingebrigtsen
2022-08-24 17:12   ` Juri Linkov
2022-08-25 14:03     ` Lars Ingebrigtsen
2022-08-25 18:02       ` Juri Linkov
2022-08-25 18:55         ` Eli Zaretskii [this message]
2022-08-25 19:35           ` Juri Linkov
2022-08-26  5:34             ` Eli Zaretskii
2022-08-26  7:17               ` Juri Linkov
2022-08-26 16:10               ` Drew Adams
2022-08-26 10:41           ` Lars Ingebrigtsen
2022-08-26 10:48             ` Eli Zaretskii
2022-08-26 16:24               ` Drew Adams
2022-08-27 13:15               ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83k06w2lwe.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=50431@debbugs.gnu.org \
    --cc=juri@linkov.net \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.