From: Eli Zaretskii <eliz@gnu.org>
To: "समीर सिंह Sameer Singh" <lumarzeli30@gmail.com>
Cc: 57846@debbugs.gnu.org
Subject: bug#57846: [PATCH] Update Unicode Support to Unicode Version 15.0.0.
Date: Fri, 16 Sep 2022 10:18:43 +0300 [thread overview]
Message-ID: <83k0634wj0.fsf@gnu.org> (raw)
In-Reply-To: <CAOR1sLzW1U664MXqODHZkH+4JBY1bQ1N0tgu+MbbVX40Xj9sqA@mail.gmail.com> (lumarzeli30@gmail.com)
> From: समीर सिंह Sameer Singh
> <lumarzeli30@gmail.com>
> Date: Fri, 16 Sep 2022 07:16:04 +0530
>
> If something is wrong with this patch please tell me.
Thank you for working on this.
> diff --git a/admin/unidata/blocks.awk b/admin/unidata/blocks.awk
> index 1c571feff3..ccfe452ceb 100755
> --- a/admin/unidata/blocks.awk
> +++ b/admin/unidata/blocks.awk
> @@ -118,6 +118,9 @@ function name2alias(name , w, w2) {
> else if (name ~ /sutton signwriting/) return "sutton-sign-writing"
> else if (name ~ /sinhala archaic number/) return "sinhala"
> else if (name ~ /tangut components/) return "tangut"
> + else if (name ~ /kawi/) return "kawi"
> + else if (name ~ /nag mundari/) return "nag-mundari"
Are these two additions really needed? The first one is just a
literal copy, and the second one is a trivial transformation that's
supposed to be handled by this rule:
gsub(/ /, "-", name)
Am I missing something?
Other than that, LGTM.
next prev parent reply other threads:[~2022-09-16 7:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-16 1:46 bug#57846: [PATCH] Update Unicode Support to Unicode Version 15.0.0 समीर सिंह Sameer Singh
2022-09-16 7:18 ` Eli Zaretskii [this message]
2022-09-16 12:05 ` समीर सिंह Sameer Singh
2022-09-17 6:53 ` Eli Zaretskii
2022-09-17 7:09 ` समीर सिंह Sameer Singh
2022-09-17 7:24 ` Eli Zaretskii
2022-09-17 7:32 ` समीर सिंह Sameer Singh
2022-09-16 7:37 ` Robert Pluim
2022-09-16 12:07 ` समीर सिंह Sameer Singh
2022-09-16 12:15 ` Eli Zaretskii
2022-09-16 12:20 ` समीर सिंह Sameer Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83k0634wj0.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=57846@debbugs.gnu.org \
--cc=lumarzeli30@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.