all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Kangas <stefankangas@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: master b306bc5e6d 2/3: Improve prompt of 'image-dired' command
Date: Sat, 24 Sep 2022 11:18:59 +0300	[thread overview]
Message-ID: <83k05tnq18.fsf@gnu.org> (raw)

> --- a/lisp/image/image-dired.el
> +++ b/lisp/image/image-dired.el
> @@ -553,7 +553,7 @@ If the number of image files in DIR exceeds
>  `image-dired-show-all-from-dir-max-files', ask for confirmation
>  before creating the thumbnail buffer.  If that variable is nil,
>  never ask for confirmation."
> -  (interactive "DImage-Dired: ")
> +  (interactive "DImage-Dired (directory): ")

IMO, the new prompt is not much better than the old one.  They both
assume that just by prepending "Image-" to something resembling the
prompt of "C-x d" is enough to explain what the command wants.  I see
a lot of space for confusion here, especially for non-native English
speakers.

The doc string of the command says:

  Make a thumbnail buffer for all images in DIR and display it.
  Any file matching `image-dired--file-name-regexp' is considered an
  image file.

So I don't think the analogy with Dired holds, and therefore something
like

  Show thumbnails for directory:

would be a better prompt.



             reply	other threads:[~2022-09-24  8:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-24  8:18 Eli Zaretskii [this message]
2022-09-24  9:22 ` master b306bc5e6d 2/3: Improve prompt of 'image-dired' command Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83k05tnq18.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=stefankangas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.