From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#58940: [PATCH] feature/tree-sitter: Add more font lock faces Date: Mon, 07 Nov 2022 05:31:26 +0200 Message-ID: <83k047zbht.fsf@gnu.org> References: <835yfxbkyy.fsf@gnu.org> <8ZKenedKBW2xqbSe_c0vWmeRbMQYCDlwFNvSMAYx9utQYeOKPHQQ-nKW9Y8nCcKRnFMmsnfonvA_0yixtSArBzVY_PkaNxxGWqhXoHjCZTo=@rjt.dev> <83cza14uuq.fsf@gnu.org> <83cza038yn.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11800"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dev@rjt.dev, casouri@gmail.com, stefankangas@gmail.com, 58940@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 07 04:32:16 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1orsrv-0002wa-Su for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 07 Nov 2022 04:32:16 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1orsrk-0008Uo-60; Sun, 06 Nov 2022 22:32:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1orsri-0008Ub-L0 for bug-gnu-emacs@gnu.org; Sun, 06 Nov 2022 22:32:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1orsri-0000S5-Bp for bug-gnu-emacs@gnu.org; Sun, 06 Nov 2022 22:32:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1orsri-0002sW-7x for bug-gnu-emacs@gnu.org; Sun, 06 Nov 2022 22:32:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 07 Nov 2022 03:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58940 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58940-submit@debbugs.gnu.org id=B58940.166779190911044 (code B ref 58940); Mon, 07 Nov 2022 03:32:02 +0000 Original-Received: (at 58940) by debbugs.gnu.org; 7 Nov 2022 03:31:49 +0000 Original-Received: from localhost ([127.0.0.1]:32822 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1orsrV-0002s3-CE for submit@debbugs.gnu.org; Sun, 06 Nov 2022 22:31:49 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:36360) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1orsrT-0002rp-SB for 58940@debbugs.gnu.org; Sun, 06 Nov 2022 22:31:48 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1orsrO-00074w-JT; Sun, 06 Nov 2022 22:31:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=jmdj0UtSdU8W/Ta+o4xQmOS/ZE5Ia5pTxR4b1JEm8xY=; b=KrOJpajRC7T1 PbIdqdTuQjBiR7U2ziVZOo8xdiy5/Jq9LaNBUFkwarQvdjMI8IJ5DDiVQZtG2/F0MQPEO4AHvBfR6 MBPn9YiOa40U61LFqqTtSiz/AncHzKTPbCV6aZLtiDQve4/b6tDFIOWrbWVotZr+8CqJvUVivPsAP /ym9JXcx6mia1+OA5lFEk/B7GsD+3iXxrgNxuzkWhN5NuMWl6Mrbp0sHmRQcly9v/wHAHWqrgn3U2 bEGxDjfbGC5//73trpJda7hqGUiT+ShVM1Dgc1wKIaVaT6i73HNzIaYeEPRRyGlXouWRvuCoAGPs4 GOtFz9euqI5Ip4KvWGedLg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1orsrN-0002mT-RY; Sun, 06 Nov 2022 22:31:42 -0500 In-Reply-To: (message from Stefan Monnier on Sun, 06 Nov 2022 20:33:18 -0500) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:247255 Archived-At: > From: Stefan Monnier > Cc: Eli Zaretskii , Randy Taylor , > casouri@gmail.com, 58940@debbugs.gnu.org > Date: Sun, 06 Nov 2022 20:33:18 -0500 > > >> I suspect that's part of the reason. Ideally, we'd phase out those old > >> `font-lock-*-face` variables rather than introduce new ones. > >> I think the only thing they bring nowadays is confusion. > > Would it be worth it to make them obsolete? > > I'd be in favor, yes. I wouldn't. There's gobs of code out there which will suddenly get warnings. For what purpose? Those variables cause no harm whatsoever. We shouldn't be too eager to obsolete things that cause us no harm.