From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#59920: [PATCH] Make checkdoc warn if not using lexical-binding Date: Sun, 11 Dec 2022 09:29:48 +0200 Message-ID: <83k02yv1n7.fsf@gnu.org> References: <83v8mkzrvj.fsf@gnu.org> <83o7sczl1x.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5521"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59920@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 11 08:30:46 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p4GnN-0001Ga-Su for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 11 Dec 2022 08:30:46 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p4GnB-0001DP-9e; Sun, 11 Dec 2022 02:30:33 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4Gml-0001AF-2D for bug-gnu-emacs@gnu.org; Sun, 11 Dec 2022 02:30:08 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p4Gmh-0003T8-00 for bug-gnu-emacs@gnu.org; Sun, 11 Dec 2022 02:30:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p4Gmg-0006GT-Qv for bug-gnu-emacs@gnu.org; Sun, 11 Dec 2022 02:30:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Dec 2022 07:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59920 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59920-submit@debbugs.gnu.org id=B59920.167074379824053 (code B ref 59920); Sun, 11 Dec 2022 07:30:02 +0000 Original-Received: (at 59920) by debbugs.gnu.org; 11 Dec 2022 07:29:58 +0000 Original-Received: from localhost ([127.0.0.1]:46163 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4Gmb-0006Ft-Sk for submit@debbugs.gnu.org; Sun, 11 Dec 2022 02:29:58 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:33648) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4GmZ-0006Fm-8W for 59920@debbugs.gnu.org; Sun, 11 Dec 2022 02:29:56 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4GmT-0003NZ-Vq; Sun, 11 Dec 2022 02:29:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=UPA8+iGhgPk6kPx2LvVfNMbLAaTMr/t/aqZZ5TgNahQ=; b=eEse9ygg1k6K tHoSv05PFCvlMMqocJdNJP45ym2Sgp8M8Tk/2O+Zi9qmSMOgft3RoAMviuLwl+DXhMqEyvJeIULqW N3+OxCfIJv0ecnYbE0JEWHSVlBFx7d1WwAvlnY3hkIzVtjWkGsZdt7b2xB5/l9wMzv/rq8fp53cDO wtHL2XQmnhVAMuwFhHcDT2JLFiqomxu9AtHgV10xchBUSPRkAve3tCc+BbQ8bx7KHB/taWs7djY6G giKhscm3+Zc4iTCsgBduwS1p4PIkGHfyOhm8jhc4ply/NM63B8jVIQY6QZ9jpYnttWUNamHFpRkHZ 9iHWtEFMIZGiF+cJmtgPCA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4GmT-0001w2-8h; Sun, 11 Dec 2022 02:29:49 -0500 In-Reply-To: (message from Stefan Kangas on Sat, 10 Dec 2022 15:26:03 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250578 Archived-At: > From: Stefan Kangas > Date: Sat, 10 Dec 2022 15:26:03 -0800 > Cc: 59920@debbugs.gnu.org > > +(defcustom checkdoc-lexical-binding-flag t > + "Non-nil means generate warnings if file is not using lexical binding. > +See Info node `(elisp) Converting to Lexical Binding' for more." > + :type 'boolean > + :version "29.1") Should be "30.1", I guess? > + (checkdoc-create-error > + "The first line should end with \"-*- lexical-binding: t -*-\"" Is this accurate? IOW, does the lexical-binding cookie have to be the last on the first line? Otherwise, LGTM, thanks.