all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: "Óscar Fuentes" <ofv@wanadoo.es>
Cc: emacs-devel@gnu.org
Subject: Re: MinGW build on master fails with Error 127
Date: Sat, 24 Dec 2022 21:27:01 +0200	[thread overview]
Message-ID: <83k02g4n7e.fsf@gnu.org> (raw)
In-Reply-To: <87mt7czk1v.fsf@telefonica.net> (message from Óscar Fuentes on Sat, 24 Dec 2022 20:19:24 +0100)

> From: Óscar Fuentes <ofv@wanadoo.es>
> Cc: emacs-devel@gnu.org
> Date: Sat, 24 Dec 2022 20:19:24 +0100
> 
> Óscar Fuentes <ofv@wanadoo.es> writes:
> 
> >>> The commit message says "fclose fail during atexit as if they were
> >>> already closed" but indeed it doesn't describe a user-visible problem. I
> >>> can ask for more details, if you are interested.
> >>
> >> I am.
> >
> > Ok, I'll ask the patch author.
> 
> This is his answer:
> 
>   Afair it showed an error at exit and exited != 0.

Here's the source code of close_stream (after I removed the comments):

  int
  close_stream (FILE *stream)
  {
    const bool some_pending = (__fpending (stream) != 0);
    const bool prev_fail = (ferror (stream) != 0);
    const bool fclose_fail = (fclose (stream) != 0);

    if (prev_fail || (fclose_fail && (some_pending || errno != EBADF)))
      {
	if (! fclose_fail)
	  errno = 0;
	return EOF;
      }

    return 0;
  }

My questions are simple: which of the conditions for the error return
actually happened?  And what was the value of 'errno' (the code only
filters out EBADF)?



  reply	other threads:[~2022-12-24 19:27 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-12 15:26 MinGW build on master fails with Error 127 Loreno Heer
2022-12-12 15:40 ` Eli Zaretskii
2022-12-12 15:44   ` Loreno Heer
2022-12-12 15:56     ` Eli Zaretskii
2022-12-12 16:03       ` Loreno Heer
2022-12-12 16:11         ` Eli Zaretskii
2022-12-12 16:54           ` Loreno Heer
2022-12-23 21:45           ` Loreno Heer
2022-12-24  6:36             ` Eli Zaretskii
2022-12-24 14:18               ` Loreno Heer
2022-12-24 14:43                 ` Eli Zaretskii
2022-12-24 15:11                   ` Loreno Heer
2022-12-24 15:44                     ` Eli Zaretskii
2022-12-24 22:50                       ` Loreno Heer
2022-12-24 15:31                   ` Óscar Fuentes
2022-12-24 15:50                     ` Eli Zaretskii
2022-12-24 16:14                       ` Óscar Fuentes
2022-12-24 16:46                         ` Eli Zaretskii
2022-12-24 16:58                           ` Óscar Fuentes
2022-12-24 17:08                           ` Óscar Fuentes
2022-12-24 17:20                             ` Eli Zaretskii
2022-12-24 17:57                               ` Óscar Fuentes
2022-12-24 18:09                                 ` Eli Zaretskii
2022-12-24 18:56                                   ` Óscar Fuentes
2022-12-24 19:10                                     ` Eli Zaretskii
2022-12-25  2:46                                       ` Óscar Fuentes
2022-12-25  8:29                                         ` Eli Zaretskii
2022-12-25 14:25                                           ` Óscar Fuentes
2022-12-26 13:02                                             ` Eli Zaretskii
2022-12-26 13:33                                               ` Óscar Fuentes
2022-12-24 19:19                                     ` Óscar Fuentes
2022-12-24 19:27                                       ` Eli Zaretskii [this message]
2022-12-25  0:13                                 ` Po Lu
2022-12-25  0:48                                   ` Óscar Fuentes
2022-12-25  6:46                                   ` Eli Zaretskii
2022-12-24 18:03                               ` Óscar Fuentes
2022-12-24 18:49                         ` Eli Zaretskii
2022-12-24 19:23                           ` Óscar Fuentes
2022-12-24 19:29                             ` Eli Zaretskii
2022-12-24 19:44                               ` Óscar Fuentes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83k02g4n7e.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=ofv@wanadoo.es \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.