From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#60376: 29.0.60; Standardize csharp-ts-mode's font-lock features Date: Fri, 30 Dec 2022 10:21:24 +0200 Message-ID: <83k029714r.fsf@gnu.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8729"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60376@debbugs.gnu.org, casouri@gmail.com, theo@thornhill.no To: jostein@kjonigsen.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 30 09:24:01 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pBAgJ-000214-Gw for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 30 Dec 2022 09:23:59 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pBAfq-0000Ah-9I; Fri, 30 Dec 2022 03:23:43 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pBAeQ-0007ne-1v for bug-gnu-emacs@gnu.org; Fri, 30 Dec 2022 03:22:39 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pBAeP-0007ut-Ln for bug-gnu-emacs@gnu.org; Fri, 30 Dec 2022 03:22:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pBAeP-0008CR-Hk for bug-gnu-emacs@gnu.org; Fri, 30 Dec 2022 03:22:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 30 Dec 2022 08:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60376 X-GNU-PR-Package: emacs Original-Received: via spool by 60376-submit@debbugs.gnu.org id=B60376.167238849531484 (code B ref 60376); Fri, 30 Dec 2022 08:22:01 +0000 Original-Received: (at 60376) by debbugs.gnu.org; 30 Dec 2022 08:21:35 +0000 Original-Received: from localhost ([127.0.0.1]:33497 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBAdy-0008Bk-RA for submit@debbugs.gnu.org; Fri, 30 Dec 2022 03:21:35 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:60792) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBAdx-0008BV-5z for 60376@debbugs.gnu.org; Fri, 30 Dec 2022 03:21:33 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pBAdq-0007nk-6y; Fri, 30 Dec 2022 03:21:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=TyRk4/iTfKpXtmeEJNoQI8Njhw+wy6q8sL+OIY6wXXc=; b=mh6//cG6RwnDMn8s8Vw2 7T2I0QK3vU3sHayIy3mZPGe+2fqYpH/T8/Hf9NrGudr+YLtuvOyeCe9JNRFTnnJUjAbk8Cnfku4H5 NXMAFYTLSRV1JpBYOj/8klzNMxrsxbcl5sBCKgYATu1IdKagpSLJSeLkRbeFyfrkMRzyuElvicEe9 /EPc+FB4MnGS4yFofm1j/9M/i+KmyRic+hrVq9LBeCcUGPdZTYLDIscT7XeK9j8DxmqDX77gnuOsX 0a9vbFau9AwquTJZhNeV+L3bvICJdKSodLytpE2xVbScz7EJy8Nia3jdIxgaLuClWmb0LISX5Jk/x QU3i+XHKP80O3Q==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pBAdp-0006aI-Ly; Fri, 30 Dec 2022 03:21:26 -0500 In-Reply-To: (message from Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= on Thu, 29 Dec 2022 22:03:06 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:252098 Archived-At: > Cc: Theodor Thornhill > Date: Thu, 29 Dec 2022 22:03:06 +0100 > From: Jostein Kjønigsen > > While standardizing font-lock features is probably a good thing, at the end of the day, it does mean changing > working code. In that regard, I'd like to ensure we don't change more than we need to, to not impose any > unneeded risk near the feature freeze and eventual Emacs 29 release. Basically, whatever objections I may > have, please assume them to be in good faith. > > As far as standardizing the features, which bar are we standardizing them against, or along with? Are other > modes getting standardized as well? In case, which? > > To take a personal nitpick as an example... python-ts-mode does not even highlight function-invocations, > despite me having sent in patches to fix that[1]? How does that play into this standardization? I can't say I've > seen much response to my bug-report or patch so far, and I mean... We can't standardize features which > are not yet even implemented, right? In which case, I feel some issues should take precedence over others. > > I'm not trying to be difficult or anything, but whenever I hear about standardization, I feel these are important > questions to ask. Left unresolved they can often leads to disenfranchising people from their own works, if > they are left feeling like they are forced to make changes they disagree with or dont see the benefits of. This is eventually up to you. You can always go with what your gut feeling is about what's TRT, and correct that later if necessary, given the user feedback and maintenance experience we collect.