From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#60411: 29.0.60; minibuffer-next-completion skips first candidate when completions-header-format and completion-show-help are nil Date: Sat, 31 Dec 2022 18:40:02 +0200 Message-ID: <83k0274jdp.fsf@gnu.org> References: <87zgb5lx6y.fsf@oracle.com> <6c9d91cffcdbff97f034@heytings.org> <87lemot7ek.fsf@gmail.com> <0a62cbaeff1ee0497715@heytings.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3726"; mail-complaints-to="usenet@ciao.gmane.io" Cc: kahatlen@gmail.com, 60411@debbugs.gnu.org To: Gregory Heytings , Stefan Monnier , Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 31 17:41:08 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pBeux-0000pA-Kt for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 31 Dec 2022 17:41:07 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pBeuu-00044j-8J; Sat, 31 Dec 2022 11:41:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pBeus-00044a-KE for bug-gnu-emacs@gnu.org; Sat, 31 Dec 2022 11:41:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pBeus-0001pi-5j for bug-gnu-emacs@gnu.org; Sat, 31 Dec 2022 11:41:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pBeur-0007UO-S1 for bug-gnu-emacs@gnu.org; Sat, 31 Dec 2022 11:41:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 31 Dec 2022 16:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60411 X-GNU-PR-Package: emacs Original-Received: via spool by 60411-submit@debbugs.gnu.org id=B60411.167250480828713 (code B ref 60411); Sat, 31 Dec 2022 16:41:01 +0000 Original-Received: (at 60411) by debbugs.gnu.org; 31 Dec 2022 16:40:08 +0000 Original-Received: from localhost ([127.0.0.1]:39712 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBeu0-0007T3-Bu for submit@debbugs.gnu.org; Sat, 31 Dec 2022 11:40:08 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:60024) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBety-0007SM-9L for 60411@debbugs.gnu.org; Sat, 31 Dec 2022 11:40:06 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pBets-0008HU-FJ; Sat, 31 Dec 2022 11:40:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=iGUKuIq1RGomlRnQHClb/QPC/cGGm64qKBO/VpMwR6Y=; b=U4tGqfjMsfHe pggujvESRHM8n81xSpljhdWszJDjyfxs38z3dKq2+jvukWGrZ3eq8mLpL+ksVd/tiTIQ3NKSwrvff FWXS94uw8utBbr8vNAQHTiJ/IqkS08+nWO27Lk1xLo0fylG11Q5jtSlJV0iwbGonDOzayO5bMAURa GrkgzQ7I7KNJTtOqk50fDgXAOFbQGbuORwVy2CaJ5FxrFfE9DI/dDezOlw/DTuk0mVRtSiXtKUZT6 sJqEcY5RnPCJj25AzoEM7WN2jstobrt4JddYkiucZsWKIMupSqy+cr+S7oP9BFABXoltW4ujutm89 3ZmLGCgBZGycD25hhez45g==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pBetr-0001ho-Nr; Sat, 31 Dec 2022 11:40:00 -0500 In-Reply-To: <0a62cbaeff1ee0497715@heytings.org> (message from Gregory Heytings on Sat, 31 Dec 2022 15:02:57 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:252205 Archived-At: > Cc: 60411@debbugs.gnu.org > Date: Sat, 31 Dec 2022 15:02:57 +0000 > From: Gregory Heytings > > > For completeness, you may consider also handling the case where > > completions-header-format is an empty string, which is another not too > > unreasonable way to disable the header. minibuffer-next-completion still > > skips the first candidate for that case. > > > > Thanks for your feedback! Indeed, that's another bug, which makes a fix > elsewhere in the code even less likely. It is fixed in the attached > patch. Can you try it? > > Eli, do you have objections to that patch? It becomes less and less to my liking, TBH: too much ad-hocery. Juri, Stefan, WDYT? is this safe enough for the release branch?