all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: manuel@ledu-giraud.fr, 62260@debbugs.gnu.org
Subject: bug#62260: 30.0.50; [PATCH] Restrict auto-save file mode
Date: Sun, 19 Mar 2023 16:11:02 +0200	[thread overview]
Message-ID: <83jzzcal1l.fsf@gnu.org> (raw)
In-Reply-To: <87r0tksyma.fsf@gmx.de> (message from Michael Albinus on Sun, 19 Mar 2023 13:40:29 +0100)

> From: Michael Albinus <michael.albinus@gmx.de>
> Cc: Manuel Giraud <manuel@ledu-giraud.fr>,  62260@debbugs.gnu.org
> Date: Sun, 19 Mar 2023 13:40:29 +0100
> 
> Tramp has no influence on the permissions of the auto-saved file.

My reading of the code in auto_save_1 is that the permission modes of
the auto-saved files for remote files are determined from their
original files, by calling file-modes (which I believe Tramp
implements?).  See the 'else' branch of this part of auto_save_1:

  /* Get visited file's mode to become the auto save file's mode.  */
  if (! NILP (BVAR (current_buffer, filename)))
    {
      if (emacs_fstatat (AT_FDCWD, SSDATA (BVAR (current_buffer, filename)),
			 &st, 0)
	  == 0)
	/* But make sure we can overwrite it later!  */
	auto_save_mode_bits = (st.st_mode | 0600) & 0777;
      else if (modes = Ffile_modes (BVAR (current_buffer, filename), Qnil),
	       FIXNUMP (modes))
	/* Remote files don't cooperate with fstatat.  */
	auto_save_mode_bits = (XFIXNUM (modes) | 0600) & 0777;
    }

If by "Tramp has no influence on the permissions of the auto-saved
file" you mean the permissions are determined by the file, not by
Tramp, then I agree.  This simply follows what we do with local files,
just by calling an Emacs primitive instead of fstatat.





  parent reply	other threads:[~2023-03-19 14:11 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-18 15:18 bug#62260: 30.0.50; [PATCH] Restrict auto-save file mode Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-18 15:43 ` Eli Zaretskii
2023-03-18 18:39   ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-18 18:47     ` Eli Zaretskii
2023-03-18 18:51       ` Eli Zaretskii
2023-03-18 19:22         ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-18 20:00           ` Eli Zaretskii
2023-03-18 20:21             ` Eli Zaretskii
2023-03-19 11:43               ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-19 12:19                 ` Eli Zaretskii
2023-03-19 12:40                   ` Michael Albinus
2023-03-19 13:56                     ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-20 11:41                       ` Michael Albinus
2023-03-20 12:22                         ` Eli Zaretskii
2023-03-20 12:31                           ` Michael Albinus
2023-03-20 14:15                         ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-19 14:11                     ` Eli Zaretskii [this message]
2023-03-20 11:43                       ` Michael Albinus
2023-03-19 14:18                     ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-20 11:44                       ` Michael Albinus
2023-03-22 10:13                         ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-23 16:26                           ` Michael Albinus
2023-03-24  7:34                             ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-24 10:35                             ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-24 17:56                               ` Michael Albinus
2023-03-18 19:16       ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83jzzcal1l.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=62260@debbugs.gnu.org \
    --cc=manuel@ledu-giraud.fr \
    --cc=michael.albinus@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.