From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#62825: 29.0.90; c-ts-mode doesn't recognize DEFUN functions Date: Sun, 16 Apr 2023 11:14:25 +0300 Message-ID: <83jzycb5we.fsf@gnu.org> References: <80353D80-21FD-4ADE-8982-4B67C59B7E7B@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1436"; mail-complaints-to="usenet@ciao.gmane.io" Cc: theo@thornhill.no, 62825@debbugs.gnu.org To: Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Apr 16 10:15:19 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pnxXb-0000Ci-PQ for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 16 Apr 2023 10:15:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pnxXM-00052G-75; Sun, 16 Apr 2023 04:15:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pnxXK-000526-8s for bug-gnu-emacs@gnu.org; Sun, 16 Apr 2023 04:15:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pnxXK-0001tN-0p for bug-gnu-emacs@gnu.org; Sun, 16 Apr 2023 04:15:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pnxXJ-0002FV-SO for bug-gnu-emacs@gnu.org; Sun, 16 Apr 2023 04:15:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 16 Apr 2023 08:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62825 X-GNU-PR-Package: emacs Original-Received: via spool by 62825-submit@debbugs.gnu.org id=B62825.16816328738593 (code B ref 62825); Sun, 16 Apr 2023 08:15:01 +0000 Original-Received: (at 62825) by debbugs.gnu.org; 16 Apr 2023 08:14:33 +0000 Original-Received: from localhost ([127.0.0.1]:50572 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pnxWr-0002EX-GV for submit@debbugs.gnu.org; Sun, 16 Apr 2023 04:14:33 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:55350) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pnxWp-0002EJ-Mo for 62825@debbugs.gnu.org; Sun, 16 Apr 2023 04:14:32 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pnxWi-0001rD-Sc; Sun, 16 Apr 2023 04:14:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=FdvCjDUzCOaGFtTWKbM0OQEe4rMW9vOv/Dy/uSeyl8s=; b=FovoAl4n6z4zvo/lROmD EvrbAfAunpBuMDH1INExvIABglqylWZdAUfrbiScGFOp8/zurvN7K5sqqdYR1SGYyVP6C4rz9cOBQ s+dvzcgewCtLCzDRz/YpkfxLsVzAp+xRjxS+0f7Yl1j3PP79xQYGus5ifE0ZybdLW5ThnkofPgmkw G7E7C5NQmnfx426ii73eM92SepcPPYAX+vyUXdmcnRBrq/fcrYf/ZTANKcYQxHZUUDmjcoSRqNmxm 2+oOwLT6zMn3p6gc3Qo0U4MhrL9TS7BEaOn1kaf0va8emlw+4VN5TVe6VJyhB3g1K8gCODNnXbOo2 BCYIzZWz+j8j2Q==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pnxWg-0001PI-PY; Sun, 16 Apr 2023 04:14:24 -0400 In-Reply-To: <80353D80-21FD-4ADE-8982-4B67C59B7E7B@gmail.com> (message from Yuan Fu on Sat, 15 Apr 2023 22:37:02 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:260102 Archived-At: > From: Yuan Fu > Date: Sat, 15 Apr 2023 22:37:02 -0700 > Cc: 62825@debbugs.gnu.org, > theo@thornhill.no > > > Eli Zaretskii writes: > > > Thanks. But I wonder why do we need the c-ts-mode-emacs-devel knob. > > Why not recognize DEFUN by default everywhere? CC Mode does that, > > AFAIK, so why shouldn't c-ts-mode do the same? > > I just thought the fix is a bit hacky, and does add some overhead, so > people who don’t need it might not be happy to know that they can’t turn > it off. OK, but I made it into a defcustom and turned this on by default. I also renamed a few symbols, please take a look. Btw, should the code you added to c-ts-mode--defun-name recognize DEFUN nodes only when this variable is non-nil?