From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64596: 30.0.50; On FIXME: in src/buffer.c:1481 (force-mode-line-update) Date: Sat, 15 Jul 2023 19:16:57 +0300 Message-ID: <83jzv1b152.fsf@gnu.org> References: <877cr4nez9.fsf@localhost> <83lefj4okb.fsf@gnu.org> <83fs5r3tqv.fsf@gnu.org> <834jm6fppc.fsf@gnu.org> <87a5vyidy6.fsf@localhost> <83sf9qe2ip.fsf@gnu.org> <83a5vxejz6.fsf@gnu.org> <83r0p9b3om.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27561"; mail-complaints-to="usenet@ciao.gmane.io" Cc: yantar92@posteo.net, 64596@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jul 15 18:17:29 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qKhxY-0006wH-RN for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 15 Jul 2023 18:17:28 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qKhxA-0006um-IC; Sat, 15 Jul 2023 12:17:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKhx8-0006nC-Ug for bug-gnu-emacs@gnu.org; Sat, 15 Jul 2023 12:17:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qKhx8-0003Rs-MQ for bug-gnu-emacs@gnu.org; Sat, 15 Jul 2023 12:17:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qKhx8-0004dm-DA for bug-gnu-emacs@gnu.org; Sat, 15 Jul 2023 12:17:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Jul 2023 16:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64596 X-GNU-PR-Package: emacs Original-Received: via spool by 64596-submit@debbugs.gnu.org id=B64596.168943781717823 (code B ref 64596); Sat, 15 Jul 2023 16:17:02 +0000 Original-Received: (at 64596) by debbugs.gnu.org; 15 Jul 2023 16:16:57 +0000 Original-Received: from localhost ([127.0.0.1]:45836 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKhx2-0004dP-EY for submit@debbugs.gnu.org; Sat, 15 Jul 2023 12:16:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54168) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKhwx-0004d9-55 for 64596@debbugs.gnu.org; Sat, 15 Jul 2023 12:16:55 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKhwq-0003Pm-56; Sat, 15 Jul 2023 12:16:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=SAPm0ps647UI4HvrdeeKQx74ma3SdMiPWH2XXqE/AGg=; b=HLofgL+TwzOL zdTTZcMXojUL/fGH1crPbYtYSdvORU50y/7vpsbnx+HCKBW7Wh1cRQGinmKMMzDPtANokAAGuZY88 hAoFO5Np7tdYeSWbcwPzmBI5aS+MNh1YJf0Cbai3vg+xLJT9pcLRjoxKNohLsmadFC334Nm7npydz 8A3p9kyWtsD/g6mJWwUxBfAiB/w9YdvZYBOrw987Q/cSm1tZGlaAyeJPEtfJU8gaGVSkwwnBHxV9d Yk2RYo9jF+K+lpqOhbl7cHRVhS7PBzJmmDVGbhgO2HRHH6rWw6y38veWUUjxsN6Y9YxKs75PFOT17 g+MEmv+AXXvzJ8nBljrGHw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKhwh-00018L-Bk; Sat, 15 Jul 2023 12:16:43 -0400 In-Reply-To: (message from Stefan Monnier on Sat, 15 Jul 2023 12:01:50 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265224 Archived-At: > From: Stefan Monnier > Cc: yantar92@posteo.net, 64596@debbugs.gnu.org > Date: Sat, 15 Jul 2023 12:01:50 -0400 > > > But what happens in reality is that the breaking changes are made, and > > then the "guilty parties" disappear into thin air, or lose interest. > > And we are left with a broken redisplay and an unfinished project. > > I didn't disappear into thin air, did I? Let's not make this too personal. Suffice it to say that I saw more than once or twice changes in these areas which caused subtle redisplay problems several years later, and I did have to fix a few of them. So what I wrote is based on facts and actual experience. > >> That's eactly what happened when I introduced the 3 `redisplay` bits > >> above: it did introduce a few bugs, but overall it made the code > >> more clear. > > No, that's not "exactly" what happened. Some of the bugs popped up > > much later, among other things. I agree that the added comments made > > the situation better, but you know as well as I do that some of the > > aspects of those variables are still somewhat mysterious: specifically > > the meaning of windows_or_buffers_changed and update_mode_lines for > > disabling optimizations and shortcuts. Which is exactly the focus of > > the current discussion. > > Those aspects are not due to my changes. If they are mysterious it's > because the remained mysterious, i.e. because I did not change them. Indeed. The above wasn't written to accuse, but to convey the fact that we are not yet where we want to be in this regard. > This said, the meaning of those vars is clear, I think (they mean, that > all the windows/modelines need to be updated). Not entirely true, AFAIU. For example, what does update_mode_lines have to do with preparing the menu bar? static void prepare_menu_bars (void) { bool all_windows = windows_or_buffers_changed || update_mode_lines; bool some_windows = REDISPLAY_SOME_P (); or a similar reference in update_menu_bar. Or why redisplay_internal does this: consider_all_windows_p = (update_mode_lines || windows_or_buffers_changed); And a couple of more "questionable" uses of that variable. > What still isn't clear at some places is the reason why they're set. Yes, that too.