time in mode-line

time in mode-line

[Colin Baxter]

After today's pull of emacs, I find the time clock display in the
mode-line has changed. Is this intentional?

1. emacs -q <RET>
2. In scratch evaluate (setq display-time-day-and-date t) and
   (display-time)
3. C-x 2 <RET>

In the inactive buffer, the clock has a background of the same color as
the active buffer mode-line. It look pretty ugly to me. 

Colin Baxter.

Re: time in mode-line

[Eli Zaretskii]

> From: Colin Baxter <m43cap@yandex.com>
> Date: Fri, 21 Jul 2023 20:02:31 +0100
> 
> 
> After today's pull of emacs, I find the time clock display in the
> mode-line has changed. Is this intentional?
> 
> 1. emacs -q <RET>
> 2. In scratch evaluate (setq display-time-day-and-date t) and
>    (display-time)
> 3. C-x 2 <RET>
> 
> In the inactive buffer, the clock has a background of the same color as
> the active buffer mode-line. It look pretty ugly to me. 

Does the patch below fix that?

diff --git a/lisp/time.el b/lisp/time.el
index 3b87859..3f10def 100644
--- a/lisp/time.el
+++ b/lisp/time.el
@@ -140,7 +140,7 @@ display-time-mail-face
   :type '(choice (const :tag "None" nil) face))
 
 (defface display-time-date-and-time
-  '((t (:inherit mode-line)))
+  '((t nil))
   "Face for `display-time-format'."
   :group 'mode-line-faces
   :version "30.1")

Re: time in mode-line

[Colin Baxter]

>>>>> Eli Zaretskii <eliz@gnu.org> writes:

    >> From: Colin Baxter <m43cap@yandex.com> Date: Fri, 21 Jul 2023
    >> 20:02:31 +0100
    >> 
    >> 
    >> After today's pull of emacs, I find the time clock display in the
    >> mode-line has changed. Is this intentional?
    >> 
    >> 1. emacs -q <RET> 2. In scratch evaluate (setq
    >> display-time-day-and-date t) and (display-time) 3. C-x 2 <RET>
    >> 
    >> In the inactive buffer, the clock has a background of the same
    >> colour as the active buffer mode-line. It look pretty ugly to me.

    > Does the patch below fix that?

Yes, it does. Thank you.


    > diff --git a/lisp/time.el b/lisp/time.el index 3b87859..3f10def
    > 100644 --- a/lisp/time.el +++ b/lisp/time.el @@ -140,7 +140,7 @@
    > display-time-mail-face :type '(choice (const :tag "None" nil)
    > face))
 
    >  (defface display-time-date-and-time - '((t (:inherit mode-line)))
    > + '((t nil)) "Face for `display-time-format'."  :group
    > 'mode-line-faces :version "30.1")


Colin Baxter.

Re: time in mode-line

[Eli Zaretskii]

> From: Colin Baxter <m43cap@yandex.com>
> Cc: emacs-devel@gnu.org
> Date: Sat, 22 Jul 2023 06:46:34 +0100
> 
> >>>>> Eli Zaretskii <eliz@gnu.org> writes:
> 
>     >> From: Colin Baxter <m43cap@yandex.com> Date: Fri, 21 Jul 2023
>     >> 20:02:31 +0100
>     >> 
>     >> 
>     >> After today's pull of emacs, I find the time clock display in the
>     >> mode-line has changed. Is this intentional?
>     >> 
>     >> 1. emacs -q <RET> 2. In scratch evaluate (setq
>     >> display-time-day-and-date t) and (display-time) 3. C-x 2 <RET>
>     >> 
>     >> In the inactive buffer, the clock has a background of the same
>     >> colour as the active buffer mode-line. It look pretty ugly to me.
> 
>     > Does the patch below fix that?
> 
> Yes, it does. Thank you.

Thanks, installed.