From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#63896: [PATCH] Support annotating and sorting the project list during completion Date: Thu, 24 Aug 2023 17:39:34 +0300 Message-ID: <83jztkpkrd.fsf@gnu.org> References: <83v8g240g6.fsf@gnu.org> <2688fc0b-6afb-7f13-1805-bf79b0fcabd3@gutov.dev> <83lee1qa8m.fsf@gnu.org> <5cbcf6cb-5abf-d911-1778-8c74c8bc9368@gutov.dev> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25766"; mail-complaints-to="usenet@ciao.gmane.io" Cc: sbaugh@janestreet.com, 63896@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 24 16:40:10 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qZBVJ-0006UT-74 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 24 Aug 2023 16:40:09 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qZBV9-0005jI-BF; Thu, 24 Aug 2023 10:39:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qZBV8-0005jA-CG for bug-gnu-emacs@gnu.org; Thu, 24 Aug 2023 10:39:58 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qZBV8-00026h-4g for bug-gnu-emacs@gnu.org; Thu, 24 Aug 2023 10:39:58 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qZBVB-00088t-Qz for bug-gnu-emacs@gnu.org; Thu, 24 Aug 2023 10:40:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 24 Aug 2023 14:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63896 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 63896-submit@debbugs.gnu.org id=B63896.169288796231240 (code B ref 63896); Thu, 24 Aug 2023 14:40:01 +0000 Original-Received: (at 63896) by debbugs.gnu.org; 24 Aug 2023 14:39:22 +0000 Original-Received: from localhost ([127.0.0.1]:38363 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZBUY-00087o-4G for submit@debbugs.gnu.org; Thu, 24 Aug 2023 10:39:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35764) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZBUW-00087b-Hm for 63896@debbugs.gnu.org; Thu, 24 Aug 2023 10:39:21 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qZBUM-0001zy-LX; Thu, 24 Aug 2023 10:39:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=MgyxfWPRsf4F/gyy0w0BcbLsRpWKcj69zYokIq4omCQ=; b=bvmUP+mtSwTs aONzAq0m0ksxtfGRM4ncHrl2NMJMVh8Vi7dXgCFC74qFuxtl874eBU7stAd24LFmegXkKTuQhS2h1 5tm8+uhYVFAw37t/tHj16f28Hl4Cwl/gZ2ho8uCYU52fjgiygTWioGZP/hsOw3zAVvuZiyg5s0TON /0/tFohvBG5omhs9tSUQmhsFOJxIadwIQP+IW3D39IqTbGQ8h40HYogQbgTDvHtxF2D7Ym3iUXItK 8XDUNHSqonQGLlLLcnreQzxuRdSfafpBaTKPw+hRNBccRKoADSjHa9VZ7HGcuyLiPfjrnk6hLjrM7 OoTDqEXp0/mpwf6Vy8SvJw==; In-Reply-To: <5cbcf6cb-5abf-d911-1778-8c74c8bc9368@gutov.dev> (message from Dmitry Gutov on Thu, 24 Aug 2023 16:08:04 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:268343 Archived-At: > Date: Thu, 24 Aug 2023 16:08:04 +0300 > Cc: sbaugh@janestreet.com, 63896@debbugs.gnu.org > From: Dmitry Gutov > > On 24/08/2023 08:29, Eli Zaretskii wrote: > >> Date: Thu, 24 Aug 2023 04:54:44 +0300 > >> Cc:63896@debbugs.gnu.org > >> From: Dmitry Gutov > >> > >> On 05/06/2023 14:23, Eli Zaretskii wrote: > >>>> + (format-mode-line mode-line-process nil nil buf))) > >>> Do you really need to call format-mode-line? My advice is to stay > >>> away of that function: it could have unpleasant side effects. > >> Does calling format-mode-line trigger extra redisplays or something? > >> That sounds unexpected. > > It reuses parts of the redisplay's code, yes. Depending what's in the > > format variable passed to format-mode-line, that could cause a variety > > of surprises, especially if :eval forms are involved. It could also > > temporarily select another window and/or buffer, if the respective > > arguments are not omitted, which could also be unexpected. > > > > IMO, this function should be used sparing and with caution. > > All right, so I guess it's the same concern: when mode-line-process > contains something unusual, possibly assigned by a derived mode. Yes.