From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#65491: [PATCH] Improve performance allocating vectors Date: Sun, 17 Sep 2023 19:44:59 +0300 Message-ID: <83jzsog35g.fsf@gnu.org> References: <6B2EDD07-AAEB-40E8-B369-F634296BD3D9@gmail.com> <83v8cagkqv.fsf@gnu.org> <83ttrugkj2.fsf@gnu.org> <83r0mygi4y.fsf@gnu.org> <8af6fa1c-4873-bd6e-e896-ab5bb8d012a2@cs.ucla.edu> <83led5gyxa.fsf@gnu.org> <83o7i0g4i9.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22444"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 65491@debbugs.gnu.org, mattias.engdegard@gmail.com, monnier@iro.umontreal.ca To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 17 18:46:19 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qhuuX-0005ZX-C9 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 17 Sep 2023 18:46:17 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qhuuE-0001dA-FD; Sun, 17 Sep 2023 12:45:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qhuuA-0001cJ-SS for bug-gnu-emacs@gnu.org; Sun, 17 Sep 2023 12:45:55 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qhuuA-0006Gd-Kh for bug-gnu-emacs@gnu.org; Sun, 17 Sep 2023 12:45:54 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qhuuI-0005V6-Ac for bug-gnu-emacs@gnu.org; Sun, 17 Sep 2023 12:46:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 17 Sep 2023 16:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65491 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 65491-submit@debbugs.gnu.org id=B65491.169496912821104 (code B ref 65491); Sun, 17 Sep 2023 16:46:02 +0000 Original-Received: (at 65491) by debbugs.gnu.org; 17 Sep 2023 16:45:28 +0000 Original-Received: from localhost ([127.0.0.1]:51290 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qhutZ-0005U9-O6 for submit@debbugs.gnu.org; Sun, 17 Sep 2023 12:45:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34574) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qhutW-0005Ts-UY for 65491@debbugs.gnu.org; Sun, 17 Sep 2023 12:45:16 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qhutI-0005sH-Oj; Sun, 17 Sep 2023 12:45:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Z9dAqtSVjw3x6bbkLSzlzYporC6vcI2yWHmIRVa/LYg=; b=nt6hI6oJ5zV4 DXI7iWnIYgEGNtJG66elfbDlZFTz1aWA5zHVtU5cDFHIPC0//jxQ7Ir20qcUEHN6+laAxb8IKQWlI B1EMSvR07Vcpoo74ph7mUo2vvuSaLpUBc2NNYSzrTLFKE04SbJvLDeoBTJDDA0miMY9+67cTEq7a2 q5y2p52SNvxmrmLM3eB2FNxuklsOj4HrNh0a5BGN2Yx0OA5Mew3GoyWKeJjvxo7olvDgK4w/Jdk81 fH2fPNMncQWcXWEkBxg+EzOalRCu6b3BR8VPSU4eZBx8iBKY9psneNaJ1ZbyW6MyQzrXeyI/5vUWA 4nvfk8pgvpxxiYtHpXOG9w==; In-Reply-To: (message from Paul Eggert on Sun, 17 Sep 2023 09:37:29 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:270713 Archived-At: > Date: Sun, 17 Sep 2023 09:37:29 -0700 > Cc: mattias.engdegard@gmail.com, 65491@debbugs.gnu.org, > monnier@iro.umontreal.ca > From: Paul Eggert > > On 2023-09-17 09:15, Eli Zaretskii wrote: > > Even though the code is so completely obfuscated and hard to > > understand? > > If it's confusing, let's add a comment. That would be better than > unnecessarily duplicating the actual code. Feel free to add any comments you find useful, that is always welcome. But comments about complicated code have one downside: they need to be updated when the code changes, and people forget to do that... > > We also have USE_LSB_TAG and LISP_WORDS_ARE_POINTERS > > Yes, and we should minimize dependencies on those macros as well. My point is that XUNTAG depends on both of those as well. > > I frequently find it easier to fire up GDB > > and ask it to show me the values > > Oh, I do that all the time too, with both Emacs and other programs. It's > OK. Why refuse help from GDB? C code is supposed to be easily readable. Going to GDB means it isn't.