From: Eli Zaretskii <eliz@gnu.org>
To: Yuan Fu <casouri@gmail.com>
Cc: 67117@debbugs.gnu.org, dvzubarev@yandex.ru
Subject: bug#67117: [PATCH] Tree-sitter: fix an issue when searching subtree backward
Date: Sun, 19 Nov 2023 08:40:51 +0200 [thread overview]
Message-ID: <83jzqekzyk.fsf@gnu.org> (raw)
In-Reply-To: <31EB2F37-286D-4910-958B-0152A85E970F@gmail.com> (message from Yuan Fu on Sat, 18 Nov 2023 22:13:49 -0800)
> From: Yuan Fu <casouri@gmail.com>
> Date: Sat, 18 Nov 2023 22:13:49 -0800
> Cc: dvzubarev@yandex.ru,
> 67117@debbugs.gnu.org
>
>
>
> > On Nov 18, 2023, at 9:47 PM, Eli Zaretskii <eliz@gnu.org> wrote:
> >
> >> From: Yuan Fu <casouri@gmail.com>
> >> Date: Sat, 18 Nov 2023 10:47:47 -0800
> >> Cc: Denis Zubarev <dvzubarev@yandex.ru>,
> >> 67117@debbugs.gnu.org
> >>
> >>
> >>>> Steps to reproduce the issue:
> >>>> 1. emacs -Q
> >>>> 2. M-x find-file /tmp/t.py
> >>>> 3. paste to the buffer
> >>>>
> >>>> Temp(1, 2)
> >>>>
> >>>> 4. M-x python-ts-mode
> >>>> 5. Call search-subtree with backward flag
> >>>> M-x eval-expression (treesit-search-subtree
> >>>> (treesit--thing-at (point) "call")
> >>>> (lambda (n) (equal (treesit-node-type n ) "integer"))
> >>>> t)
> >>>> It should return the second int node (#<treesit-node integer in 9-10>), but it returns nil.
> >>>
> >>> Yuan, any comments to the patch and the issue in general?
> >>
> >> LGTM. Thanks Denis, and Eli :-)
> >
> > Should we install this on the emacs-29 branch or on master?
>
> Emacs-29, I’d say, since it’s a bug fix. Why do you ask?
Because I want to install it, obviously.
next prev parent reply other threads:[~2023-11-19 6:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-11 23:38 bug#67117: [PATCH] Tree-sitter: fix an issue when searching subtree backward Denis Zubarev
2023-11-15 13:21 ` Eli Zaretskii
2023-11-15 17:01 ` Eli Zaretskii
2023-11-18 18:47 ` Yuan Fu
2023-11-19 5:47 ` Eli Zaretskii
2023-11-19 6:13 ` Yuan Fu
2023-11-19 6:40 ` Eli Zaretskii [this message]
2023-11-21 4:23 ` Yuan Fu
2023-11-21 11:43 ` Eli Zaretskii
2023-11-25 3:44 ` Yuan Fu
2023-11-19 9:15 ` Eli Zaretskii
2023-11-19 11:25 ` Denis Zubarev
2023-11-19 11:45 ` Eli Zaretskii
2023-12-19 0:24 ` Denis Zubarev
2023-12-19 2:26 ` Yuan Fu
2023-12-19 16:52 ` Eli Zaretskii
2023-12-19 17:08 ` Denis Zubarev
2023-12-23 7:09 ` Yuan Fu
2023-12-26 0:39 ` Yuan Fu
2023-12-19 3:24 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83jzqekzyk.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=67117@debbugs.gnu.org \
--cc=casouri@gmail.com \
--cc=dvzubarev@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.