From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Unified mouse-highlight code needs testing Date: Sat, 06 Nov 2010 10:56:43 +0200 Message-ID: <83iq0aomno.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1289033813 22283 80.91.229.12 (6 Nov 2010 08:56:53 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 6 Nov 2010 08:56:53 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Nov 06 09:56:49 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PEeZs-0001Es-HC for ged-emacs-devel@m.gmane.org; Sat, 06 Nov 2010 09:56:48 +0100 Original-Received: from localhost ([127.0.0.1]:58493 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PEeZr-0004oQ-Pq for ged-emacs-devel@m.gmane.org; Sat, 06 Nov 2010 04:56:47 -0400 Original-Received: from [140.186.70.92] (port=58241 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PEeZk-0004o8-Ui for emacs-devel@gnu.org; Sat, 06 Nov 2010 04:56:41 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PEeZj-0004Tq-0c for emacs-devel@gnu.org; Sat, 06 Nov 2010 04:56:40 -0400 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:46255) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PEeZi-0004TX-QM for emacs-devel@gnu.org; Sat, 06 Nov 2010 04:56:38 -0400 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0LBG00000GS3AS00@a-mtaout20.012.net.il> for emacs-devel@gnu.org; Sat, 06 Nov 2010 10:56:37 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([77.126.249.126]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LBG000TPGUC6F10@a-mtaout20.012.net.il> for emacs-devel@gnu.org; Sat, 06 Nov 2010 10:56:37 +0200 (IST) X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:132411 Archived-At: I've committed a few minutes ago to the trunk revision 102261, which unifies the mouse-highlight code for all sessions, including GUI sessions and text terminals that support the mouse (GPM and MSDOS). There's now only one set of note_FOO_highlight functions (in xdisp.c) and their subroutines that determine which parts of the displayed text should be highlighted. The only display-specific part is a single function which actually draws a given glyph row in mouse-face. I tested this on MS-Windows (as a representative of GUI sessions) and on MSDOS. I don't have access to a system with GPM which actually has a mouse, so I could only make sure it builds with GPM and runs correctly without a mouse. I also made sure the X build compiles and links. Please test the new code on a TTY with GPM, on X, and on NS. On a TTY with GPM, the immediate bonus from this unification is that now mode line, header line, and overlays that specify mouse-face should all be highlighted when the mouse hovers above them. The easiest way of testing this is in Info: you have there the mode line, the header line, and the bread crumbs which all specify mouse-face; these should all work now. It is also important to test this in a session that has both X and TTY frames, especially if the TTY frame uses GPM. Thanks in advance.