erc-notifications.el

erc-notifications.el

[Eli Zaretskii]

This file's name clashes with erc-notify.el under 8+3 truncation.  Can
it be renamed, please?  Or maybe just add its contents to
erc-notify.el?

TIA

P.S. Sorry I didn't pay attention to this conflict earlier.

Re: erc-notifications.el

[Julien Danjou]

[-- Attachment #1: Type: text/plain, Size: 554 bytes --]

On Tue, Oct 02 2012, Eli Zaretskii wrote:

> This file's name clashes with erc-notify.el under 8+3 truncation.  Can
> it be renamed, please?

I'm not against it, but I'm having a hard time finding a better name.
It's an erc module using notifications.el to notify the user.

I'll try to find something.

> Or maybe just add its contents to erc-notify.el?

Unfortunately, it has nothing to do with erc-notify.el which does
something totally different.

-- 
Julien Danjou
;; Free Software hacker & freelance
;; http://julien.danjou.info

[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]

Re: erc-notifications.el

[Karl Fogel]

[-- Attachment #1: Type: text/plain, Size: 539 bytes --]

Julien Danjou <julien@danjou.info> writes:
>On Tue, Oct 02 2012, Eli Zaretskii wrote:
>
>> This file's name clashes with erc-notify.el under 8+3 truncation.  Can
>> it be renamed, please?
>
>I'm not against it, but I'm having a hard time finding a better name.
>It's an erc module using notifications.el to notify the user.
>
>I'll try to find something.

erc-via-notifications.el ?

-K

>> Or maybe just add its contents to erc-notify.el?
>
>Unfortunately, it has nothing to do with erc-notify.el which does
>something totally different.

[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]

Re: erc-notifications.el

[Eli Zaretskii]

> From: Karl Fogel <kfogel@red-bean.com>
> Cc: emacs-devel@gnu.org
> Date: Tue, 02 Oct 2012 13:43:53 -0500
> 
> erc-via-notifications.el ?

Or maybe erc-desktop-notifications.el?  (notifications.el announces
itself as "Client interface to desktop notifications".)

Thanks.

Re: erc-notifications.el

[Karl Fogel]

Eli Zaretskii <eliz@gnu.org> writes:
>> From: Karl Fogel <kfogel@red-bean.com>
>> Cc: emacs-devel@gnu.org
>> Date: Tue, 02 Oct 2012 13:43:53 -0500
>> 
>> erc-via-notifications.el ?
>
>Or maybe erc-desktop-notifications.el?  (notifications.el announces
>itself as "Client interface to desktop notifications".)

Ah, that's much better, yes!

Re: erc-notifications.el

[Julien Danjou]

[-- Attachment #1: Type: text/plain, Size: 440 bytes --]

On Tue, Oct 02 2012, Eli Zaretskii wrote:

> Or maybe erc-desktop-notifications.el?  (notifications.el announces
> itself as "Client interface to desktop notifications".)

In your opinion(s), should I just rename the file and changes the
provide/autoload call, or would it be better to change functions name
prefix, etc too, to be consistent?

-- 
Julien Danjou
-- Free Software hacker & freelance
-- http://julien.danjou.info

[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]

Re: erc-notifications.el

[Stefan Monnier]

>> Or maybe erc-desktop-notifications.el?  (notifications.el announces
>> itself as "Client interface to desktop notifications".)
> In your opinion(s), should I just rename the file and changes the
> provide/autoload call, or would it be better to change functions name
> prefix, etc too, to be consistent?

Just the file name, not the prefix of the functions/vars/...


        Stefan

Re: erc-notifications.el

[Eli Zaretskii]

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Date: Thu, 04 Oct 2012 08:30:28 -0400
> Cc: Karl Fogel <kfogel@red-bean.com>, emacs-devel@gnu.org
> 
> >> Or maybe erc-desktop-notifications.el?  (notifications.el announces
> >> itself as "Client interface to desktop notifications".)
> > In your opinion(s), should I just rename the file and changes the
> > provide/autoload call, or would it be better to change functions name
> > prefix, etc too, to be consistent?
> 
> Just the file name, not the prefix of the functions/vars/...

And, btw, another, possibly easier to grok, file name would be
erc-dbus.el.

Thanks.