From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#12881: Assume at least POSIX.1-1988 for fcntl.h Date: Thu, 15 Nov 2012 19:42:51 +0200 Message-ID: <83ip96u5ic.fsf@gnu.org> References: <50A34A56.9080007@cs.ucla.edu> <83y5i4t7gm.fsf@gnu.org> <50A48C67.7020603@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1353001408 21120 80.91.229.3 (15 Nov 2012 17:43:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 15 Nov 2012 17:43:28 +0000 (UTC) Cc: 12881@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Nov 15 18:43:38 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TZ3TW-0004Io-3n for geb-bug-gnu-emacs@m.gmane.org; Thu, 15 Nov 2012 18:43:38 +0100 Original-Received: from localhost ([::1]:34642 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TZ3TM-0002SL-Bj for geb-bug-gnu-emacs@m.gmane.org; Thu, 15 Nov 2012 12:43:28 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:34803) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TZ3TH-0002RY-JB for bug-gnu-emacs@gnu.org; Thu, 15 Nov 2012 12:43:26 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TZ3TE-0000ku-H7 for bug-gnu-emacs@gnu.org; Thu, 15 Nov 2012 12:43:23 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:35438) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TZ3TE-0000ko-DI for bug-gnu-emacs@gnu.org; Thu, 15 Nov 2012 12:43:20 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TZ3Tu-00058N-6y for bug-gnu-emacs@gnu.org; Thu, 15 Nov 2012 12:44:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Nov 2012 17:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12881 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 12881-submit@debbugs.gnu.org id=B12881.135300139519672 (code B ref 12881); Thu, 15 Nov 2012 17:44:02 +0000 Original-Received: (at 12881) by debbugs.gnu.org; 15 Nov 2012 17:43:15 +0000 Original-Received: from localhost ([127.0.0.1]:45688 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TZ3T9-00057E-7L for submit@debbugs.gnu.org; Thu, 15 Nov 2012 12:43:15 -0500 Original-Received: from mtaout23.012.net.il ([80.179.55.175]:62530) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TZ3T6-000574-2S for 12881@debbugs.gnu.org; Thu, 15 Nov 2012 12:43:13 -0500 Original-Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0MDJ00L00IH7HW00@a-mtaout23.012.net.il> for 12881@debbugs.gnu.org; Thu, 15 Nov 2012 19:42:28 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MDJ00LRSIISCS50@a-mtaout23.012.net.il>; Thu, 15 Nov 2012 19:42:28 +0200 (IST) In-reply-to: <50A48C67.7020603@cs.ucla.edu> X-012-Sender: halo1@inter.net.il X-Spam-Score: 1.5 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-Spam-Score: 1.5 (+) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:66964 Archived-At: > Date: Wed, 14 Nov 2012 22:32:07 -0800 > From: Paul Eggert > CC: 12881@debbugs.gnu.org > > > In several places, it actually changes the code involved > > in dealing with the related issues. Here's one example: > > As far as I know, that is the only example involving O_NONBLOCK. > > > Here, the code that was left is identical to the one used by platforms > > with O_NONBLOCK, but the code used by platforms with O_NDELAY was > > different in non-trivial ways. > > Do those differences matter for Microsoft platforms? I don't know, I will have to take a closer look. > > Another potential problem is that the Windows emulation of fcntl only > > works for sockets, whereas O_NONBLOCK is now used in other system > > calls, like in emacs_open etc. > > emacs_open is the only other system call where it's used, and there it's > used only in code that is "#ifndef DOS_NT", so it should be OK. > > > This patch also modifies code unrelated to O_NONBLOCK, like this one: > > That's OK, as this patch is about all symbols defined by fcntl.h > in POSIX.1-1988, not just about O_NONBLOCK. Then perhaps the problem is much smaller than I thought. > Attached is a revised patch, relative to trunk bzr 110904, > and with the above extra change. Thanks, please hold on to it for a few days, until I or someone else will have time to study it more closely.