From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#13981: 24.3.50; Incorrect declaration of image_background Date: Sun, 17 Mar 2013 05:48:02 +0200 Message-ID: <83ip4q3cwd.fsf@gnu.org> References: <5144CE95.6010600@cornell.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1363492183 11521 80.91.229.3 (17 Mar 2013 03:49:43 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 17 Mar 2013 03:49:43 +0000 (UTC) Cc: 13981@debbugs.gnu.org To: Ken Brown Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Mar 17 04:50:08 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UH4bj-0002tN-DE for geb-bug-gnu-emacs@m.gmane.org; Sun, 17 Mar 2013 04:50:03 +0100 Original-Received: from localhost ([::1]:45080 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UH4bM-0007Tv-EV for geb-bug-gnu-emacs@m.gmane.org; Sat, 16 Mar 2013 23:49:40 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:54148) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UH4bJ-0007Tf-Fc for bug-gnu-emacs@gnu.org; Sat, 16 Mar 2013 23:49:38 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UH4bI-0007z4-Ft for bug-gnu-emacs@gnu.org; Sat, 16 Mar 2013 23:49:37 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:54215) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UH4bI-0007yx-Bz for bug-gnu-emacs@gnu.org; Sat, 16 Mar 2013 23:49:36 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1UH4cf-0002OA-NN for bug-gnu-emacs@gnu.org; Sat, 16 Mar 2013 23:51:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 17 Mar 2013 03:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13981 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 13981-submit@debbugs.gnu.org id=B13981.13634922109100 (code B ref 13981); Sun, 17 Mar 2013 03:51:01 +0000 Original-Received: (at 13981) by debbugs.gnu.org; 17 Mar 2013 03:50:10 +0000 Original-Received: from localhost ([127.0.0.1]:58324 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UH4bq-0002Mj-Av for submit@debbugs.gnu.org; Sat, 16 Mar 2013 23:50:10 -0400 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:45522) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UH4bn-0002M7-Qy for 13981@debbugs.gnu.org; Sat, 16 Mar 2013 23:50:09 -0400 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0MJS00F00CZVL700@a-mtaout20.012.net.il> for 13981@debbugs.gnu.org; Sun, 17 Mar 2013 05:47:59 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MJS00FFQD7Z96C0@a-mtaout20.012.net.il>; Sun, 17 Mar 2013 05:47:59 +0200 (IST) In-reply-to: <5144CE95.6010600@cornell.edu> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:72612 Archived-At: > Date: Sat, 16 Mar 2013 15:57:09 -0400 > From: Ken Brown > > image_background() is declared in dispextern.h with a return type of > `unsigned long'. But it is defined in image.c with a return type of > RGB_PIXEL_COLOR, where the latter is a platform-dependent macro defined > in image.c. > > By luck, this doesn't cause any problems in the currently-supported > platforms. But it will cause problems in the cygw32 build on 64-bit > Cygwin (which is currently under development). The attached patch fixes > this by moving the definition of RGB_PIXEL_COLOR to dispextern.h and > changing the return type in the declaration. > > OK to apply? Yes, but please move the definition of RGB_PIXEL_COLOR so it is just before the prototype of image_background, since that is its only user. Thanks.