all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Ken Brown <kbrown@cornell.edu>
Cc: 13981@debbugs.gnu.org
Subject: bug#13981: 24.3.50; Incorrect declaration of image_background
Date: Sun, 17 Mar 2013 05:48:02 +0200	[thread overview]
Message-ID: <83ip4q3cwd.fsf@gnu.org> (raw)
In-Reply-To: <5144CE95.6010600@cornell.edu>

> Date: Sat, 16 Mar 2013 15:57:09 -0400
> From: Ken Brown <kbrown@cornell.edu>
> 
> image_background() is declared in dispextern.h with a return type of 
> `unsigned long'.  But it is defined in image.c with a return type of 
> RGB_PIXEL_COLOR, where the latter is a platform-dependent macro defined 
> in image.c.
> 
> By luck, this doesn't cause any problems in the currently-supported 
> platforms.  But it will cause problems in the cygw32 build on 64-bit 
> Cygwin (which is currently under development).  The attached patch fixes 
> this by moving the definition of RGB_PIXEL_COLOR to dispextern.h and 
> changing the return type in the declaration.
> 
> OK to apply?

Yes, but please move the definition of RGB_PIXEL_COLOR so it is just
before the prototype of image_background, since that is its only user.

Thanks.





  reply	other threads:[~2013-03-17  3:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-16 19:57 bug#13981: 24.3.50; Incorrect declaration of image_background Ken Brown
2013-03-17  3:48 ` Eli Zaretskii [this message]
2013-03-17 14:36   ` Ken Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83ip4q3cwd.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=13981@debbugs.gnu.org \
    --cc=kbrown@cornell.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.