Broken bootstrap in r113623

Broken bootstrap in r113623

[Dmitry Antipov]

...
make[3]: Entering directory `/home/dima/work/stuff/emacs/trunk/build-debug/doc/emacs'
/bin/makeinfo --force --enable-encoding -I /home/dima/work/stuff/emacs/trunk/doc/emacs --no-split -o /home/dima/work/stuff/emacs/trunk/doc/emacs/../../info/emacs.info 
/home/dima/work/stuff/emacs/trunk/doc/emacs/emacs.texi
/home/dima/work/stuff/emacs/trunk/doc/emacs/emacs.texi:547: Cross reference to nonexistent node `Disabling Multibyte' (perhaps incorrect sectioning?).
make[3]: *** [/home/dima/work/stuff/emacs/trunk/doc/emacs/../../info/emacs.info] Error 1
...

Dmitry

Re: Broken bootstrap in r113623

[Eli Zaretskii]

> Date: Wed, 31 Jul 2013 18:45:43 +0400
> From: Dmitry Antipov <dmantipov@yandex.ru>
> Cc: Xue Fuqiao <xfq.free@gmail.com>
> 
> ...
> make[3]: Entering directory `/home/dima/work/stuff/emacs/trunk/build-debug/doc/emacs'
> /bin/makeinfo --force --enable-encoding -I /home/dima/work/stuff/emacs/trunk/doc/emacs --no-split -o /home/dima/work/stuff/emacs/trunk/doc/emacs/../../info/emacs.info 
> /home/dima/work/stuff/emacs/trunk/doc/emacs/emacs.texi
> /home/dima/work/stuff/emacs/trunk/doc/emacs/emacs.texi:547: Cross reference to nonexistent node `Disabling Multibyte' (perhaps incorrect sectioning?).
> make[3]: *** [/home/dima/work/stuff/emacs/trunk/doc/emacs/../../info/emacs.info] Error 1
> ...

Fixed.

Xue, please in the future always run "make info" whenever you make any
changes in the manual.  Otherwise, the risk of gratuitously breaking
the build is quite high.

Please also make a point of mentioning _all_ of your changes in
ChangeLog entries (in this case, the removal of the "Disabling
Multibyte" node was never mentioned).

Finally, please use meaningful commit messages.  Something like "Doc
fix" does not have any meaningful information, and thus is useless.
We use "Doc fix" when making changes to doc strings of Lisp functions,
but then we always state the name of the function whose doc string was
fixed, and in any case calling 5 non-trivial changes "Doc fix" is not
a good idea.  Think about the plight of someone who wants to get a
quick overview of a series of changes by doing "bzr log -l10 --line".

Re: Broken bootstrap in r113623

[Xue Fuqiao]

On Thu, Aug 1, 2013 at 12:28 AM, Eli Zaretskii <eliz@gnu.org> wrote:
> Xue, please in the future always run "make info" whenever you make any
> changes in the manual.  Otherwise, the risk of gratuitously breaking
> the build is quite high.
>
> Please also make a point of mentioning _all_ of your changes in
> ChangeLog entries (in this case, the removal of the "Disabling
> Multibyte" node was never mentioned).
>
> Finally, please use meaningful commit messages.  Something like "Doc
> fix" does not have any meaningful information, and thus is useless.
> We use "Doc fix" when making changes to doc strings of Lisp functions,
> but then we always state the name of the function whose doc string was
> fixed, and in any case calling 5 non-trivial changes "Doc fix" is not
> a good idea.  Think about the plight of someone who wants to get a
> quick overview of a series of changes by doing "bzr log -l10 --line".

I see, thanks.

-- 
Best regards, Xue Fuqiao.