From: Eli Zaretskii <eliz@gnu.org>
To: esr@thyrsus.com (Eric S. Raymond)
Cc: emacs-devel@gnu.org
Subject: Re: VCSWITNESS = fail ** 2
Date: Sun, 12 Jan 2014 18:27:48 +0200 [thread overview]
Message-ID: <83iotp88sb.fsf@gnu.org> (raw)
In-Reply-To: <20140112143733.B3F863811D4@snark.thyrsus.com>
> From: esr@thyrsus.com (Eric S. Raymond)
> Date: Sun, 12 Jan 2014 09:37:33 -0500 (EST)
>
> Nobody has stepped up to own or defend this code in Makefile.in:
You didn't wait nowhere near enough time to draw that conclusion.
Some of us live in different time zones than you do. Moreover, for
some of us today is a weekday, not a weekend, and I, for instance,
cannot reply to my gnu.org email during office hours, for boring
reasons.
Please always wait for at least a day, if not longer, before you
conclude that no one responded.
> src: Makefile FRC
> dirstate='.bzr/checkout/dirstate'; \
> vcswitness='$$(srcdir)/../'$$dirstate; \
> [ -r "$(srcdir)/$$dirstate" ] || vcswitness=''; \
> cd $@ || exit; \
> boot=bootstrap-emacs$(EXEEXT); \
> [ ! -x "$$boot" ] || boot=''; \
> $(MAKE) all $(MFLAGS) \
> CC='${CC}' CFLAGS='${CFLAGS}' CPPFLAGS='${CPPFLAGS}' \
> LDFLAGS='${LDFLAGS}' MAKE='${MAKE}' BOOTSTRAPEMACS="$$boot" \
> VCSWITNESS="$$vcswitness"
>
> Which is just as well, because the second through fourth lines
>
> dirstate='.bzr/checkout/dirstate'; \
> vcswitness='$$(srcdir)/../'$$dirstate; \
> [ -r "$(srcdir)/$$dirstate" ] || vcswitness=''; \
>
> are a case study in how not to do things. First, they're broken. The
> readability test on line 4 is not checking the same file path that is
> set on line 3.
AFAICS, that's because the test is done first from $(srcdir), and then
from $(srcdir)/src. Thus, the value passed to src/Makefile needs an
extra "..".
> The contingent result with the current repo tree structure
> is that vcswitness is never set.
Isn't the problem in this line:
VCSWITNESS="$$vcswitness"
Shouldn't that be
VCSWITNESS="$vcswitness"
instead?
> Now let's look at what VCSWITNESS is used for. The key lines are
> in src/Makefile.in:
>
> ## VCSWITNESS points to the file that holds info about the current checkout.
> ## We use it as a heuristic to decide when to rebuild loaddefs.el.
> ## If empty it is ignored; the parent makefile can set it to some other value.
> VCSWITNESS =
>
> $(lispsource)/loaddefs.el: $(BOOTSTRAPEMACS) $(VCSWITNESS)
> cd ../lisp; $(MAKE) $(MFLAGS) autoloads EMACS="$(bootstrap_exe)"
>
> This test is wrong. The correct prerequisites would be every elisp
> file that declares an autoload cookie.
That possibility was considered and rejected, for the reasons that
Stefan explained. So you have just made things worse, not better.
> I'm going to delete the broken code.
I'm going to revert that change, unless I hear some objections. Then
we can discuss how to fix this (assuming it is broken, which I'm not
sure it is yet).
next prev parent reply other threads:[~2014-01-12 16:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-12 14:37 VCSWITNESS = fail ** 2 Eric S. Raymond
2014-01-12 15:02 ` Lars Magne Ingebrigtsen
2014-01-12 15:17 ` Eric S. Raymond
2014-01-12 17:28 ` Eli Zaretskii
2014-01-12 16:27 ` Eli Zaretskii [this message]
2014-01-12 16:45 ` Eric S. Raymond
2014-01-12 17:36 ` Eli Zaretskii
2014-01-12 18:04 ` Eli Zaretskii
2014-01-12 18:45 ` Eric S. Raymond
2014-01-12 18:53 ` Eli Zaretskii
2014-01-12 19:10 ` Glenn Morris
2014-01-12 21:00 ` Eli Zaretskii
2014-01-13 2:31 ` Glenn Morris
2014-01-12 19:25 ` David Kastrup
2014-01-12 19:42 ` Eric S. Raymond
2014-01-12 20:02 ` David Kastrup
2014-01-12 21:04 ` Eli Zaretskii
2014-01-13 15:41 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83iotp88sb.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=esr@thyrsus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.