From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#18136: 24.4.50; crash in redisplay when calling load-theme Date: Tue, 29 Jul 2014 19:31:21 +0300 Message-ID: <83iomgt9d2.fsf@gnu.org> References: <87d2cpxaq1.fsf@holos.localdomain> <8338dkh6wo.fsf@gnu.org> <53D77B06.8040907@gmx.at> <83tx60fjnh.fsf@gnu.org> <53D7A965.30700@gmx.at> <83mwbste5o.fsf@gnu.org> <53D7C0C4.7070406@gmx.at> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1406651544 12198 80.91.229.3 (29 Jul 2014 16:32:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 29 Jul 2014 16:32:24 +0000 (UTC) Cc: mvoteiza@udel.edu, 18136@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jul 29 18:32:15 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XCAJz-0001aN-Jp for geb-bug-gnu-emacs@m.gmane.org; Tue, 29 Jul 2014 18:32:15 +0200 Original-Received: from localhost ([::1]:47018 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XCAJz-0001CM-2S for geb-bug-gnu-emacs@m.gmane.org; Tue, 29 Jul 2014 12:32:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33817) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XCAJr-0001C1-IR for bug-gnu-emacs@gnu.org; Tue, 29 Jul 2014 12:32:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XCAJm-0003KP-GC for bug-gnu-emacs@gnu.org; Tue, 29 Jul 2014 12:32:07 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:46963) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XCAJm-0003KL-DK for bug-gnu-emacs@gnu.org; Tue, 29 Jul 2014 12:32:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XCAJl-0005W7-Sb for bug-gnu-emacs@gnu.org; Tue, 29 Jul 2014 12:32:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 29 Jul 2014 16:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18136 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18136-submit@debbugs.gnu.org id=B18136.140665147921148 (code B ref 18136); Tue, 29 Jul 2014 16:32:01 +0000 Original-Received: (at 18136) by debbugs.gnu.org; 29 Jul 2014 16:31:19 +0000 Original-Received: from localhost ([127.0.0.1]:42229 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XCAJ1-0005Uz-MH for submit@debbugs.gnu.org; Tue, 29 Jul 2014 12:31:19 -0400 Original-Received: from mtaout25.012.net.il ([80.179.55.181]:39806) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XCAIw-0005Ue-O6 for 18136@debbugs.gnu.org; Tue, 29 Jul 2014 12:31:14 -0400 Original-Received: from conversion-daemon.mtaout25.012.net.il by mtaout25.012.net.il (HyperSendmail v2007.08) id <0N9H00B00EQFLJ00@mtaout25.012.net.il> for 18136@debbugs.gnu.org; Tue, 29 Jul 2014 19:26:23 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout25.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N9H00501EZYVR70@mtaout25.012.net.il>; Tue, 29 Jul 2014 19:26:23 +0300 (IDT) In-reply-to: <53D7C0C4.7070406@gmx.at> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:91947 Archived-At: > Date: Tue, 29 Jul 2014 17:41:56 +0200 > From: martin rudalics > CC: mvoteiza@udel.edu, 18136@debbugs.gnu.org > > > E.g., with your suggested semantics, what would you expect from this: > > > > emacs -Q > > M-: (frame-height) RET > > M-x menu-bar-mode RET > > M-: (frame-height) RET > > > > Would you expect to see the 2 results of frame-height identical or > > different? > > Ideally different in fullscreen/maximized/fullheight mode or with > `frame-inhibit-implied-resize' non-nil, identical otherwise. Shouldn't TTY frames behave as if they were fullscreen? That's what they (normally) are, right? > > Again, FrameRows and FrameCols updates are triggered in 3 possible > > ways: > > > > . when the terminal is created > > > > . when we get SIGWINCH > > > > . when we call change_frame_size > > > > The last one was missing, which caused bug #17875, whereby switching > > to a different frame on the same terminal failed to update FrameRows > > and FrameCols, because neither of the first 2 triggers happened. > > My bad. For some reason I thought these were set in change_frame_size. > Is calling change_frame_size necessary when switching frames? What a > strange thing to do. No, my bad, sorry. I confused this code with a similar one on do_switch_frame, which was added due to bug #17875. Obviously, do_switch_frame _is_ called when we switch frames. The code in change_frame_size_1 we are talking about was there since a very long time (I see it in Emacs 21), and its purpose is to update FrameRows and FrameCols when the user changes dimensions of a TTY frame (e.g., by calling set-frame-height). If you remove it, how can we update those attributes otherwise?