From: Eli Zaretskii <eliz@gnu.org>
To: martin rudalics <rudalics@gmx.at>
Cc: mvoteiza@udel.edu, 18136@debbugs.gnu.org
Subject: bug#18136: 24.4.50; crash in redisplay when calling load-theme
Date: Tue, 29 Jul 2014 19:31:21 +0300 [thread overview]
Message-ID: <83iomgt9d2.fsf@gnu.org> (raw)
In-Reply-To: <53D7C0C4.7070406@gmx.at>
> Date: Tue, 29 Jul 2014 17:41:56 +0200
> From: martin rudalics <rudalics@gmx.at>
> CC: mvoteiza@udel.edu, 18136@debbugs.gnu.org
>
> > E.g., with your suggested semantics, what would you expect from this:
> >
> > emacs -Q
> > M-: (frame-height) RET
> > M-x menu-bar-mode RET
> > M-: (frame-height) RET
> >
> > Would you expect to see the 2 results of frame-height identical or
> > different?
>
> Ideally different in fullscreen/maximized/fullheight mode or with
> `frame-inhibit-implied-resize' non-nil, identical otherwise.
Shouldn't TTY frames behave as if they were fullscreen? That's what
they (normally) are, right?
> > Again, FrameRows and FrameCols updates are triggered in 3 possible
> > ways:
> >
> > . when the terminal is created
> >
> > . when we get SIGWINCH
> >
> > . when we call change_frame_size
> >
> > The last one was missing, which caused bug #17875, whereby switching
> > to a different frame on the same terminal failed to update FrameRows
> > and FrameCols, because neither of the first 2 triggers happened.
>
> My bad. For some reason I thought these were set in change_frame_size.
> Is calling change_frame_size necessary when switching frames? What a
> strange thing to do.
No, my bad, sorry. I confused this code with a similar one on
do_switch_frame, which was added due to bug #17875. Obviously,
do_switch_frame _is_ called when we switch frames.
The code in change_frame_size_1 we are talking about was there since a
very long time (I see it in Emacs 21), and its purpose is to update
FrameRows and FrameCols when the user changes dimensions of a TTY
frame (e.g., by calling set-frame-height). If you remove it, how can
we update those attributes otherwise?
next prev parent reply other threads:[~2014-07-29 16:31 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-29 0:36 bug#18136: 24.4.50; crash in redisplay when calling load-theme Mark Oteiza
2014-07-29 9:05 ` Eli Zaretskii
2014-07-29 10:44 ` martin rudalics
2014-07-29 12:12 ` Eli Zaretskii
2014-07-29 14:02 ` martin rudalics
2014-07-29 14:47 ` Eli Zaretskii
2014-07-29 15:41 ` martin rudalics
2014-07-29 16:31 ` Eli Zaretskii [this message]
2014-07-29 18:23 ` martin rudalics
2014-07-29 18:29 ` Eli Zaretskii
2014-07-30 16:45 ` martin rudalics
2014-07-30 17:18 ` Eli Zaretskii
2014-07-30 17:36 ` martin rudalics
2014-07-30 17:52 ` Eli Zaretskii
2014-07-31 8:49 ` martin rudalics
2014-07-31 10:52 ` Eli Zaretskii
2014-07-31 16:53 ` martin rudalics
2014-07-31 17:55 ` Eli Zaretskii
2014-08-01 8:57 ` martin rudalics
2014-08-01 12:55 ` Eli Zaretskii
2014-08-04 17:23 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83iomgt9d2.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=18136@debbugs.gnu.org \
--cc=mvoteiza@udel.edu \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.