From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#18302: MSYS2 build issues Date: Thu, 21 Aug 2014 22:22:36 +0300 Message-ID: <83iollbqbn.fsf@gnu.org> References: <83zjezb00n.fsf@gnu.org> <83y4ujaxiv.fsf@gnu.org> <83tx55c3to.fsf@gnu.org> <53F63C95.6030303@cornell.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1408649009 8286 80.91.229.3 (21 Aug 2014 19:23:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 21 Aug 2014 19:23:29 +0000 (UTC) Cc: karol.ostrovsky@gmail.com, chriszheng99@gmail.com, 18302@debbugs.gnu.org To: Ken Brown Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Aug 21 21:23:21 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XKXx9-00089c-Ik for geb-bug-gnu-emacs@m.gmane.org; Thu, 21 Aug 2014 21:23:19 +0200 Original-Received: from localhost ([::1]:33782 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XKXx9-00049B-0s for geb-bug-gnu-emacs@m.gmane.org; Thu, 21 Aug 2014 15:23:19 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43539) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XKXx1-000487-4M for bug-gnu-emacs@gnu.org; Thu, 21 Aug 2014 15:23:16 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XKXws-0002uE-4m for bug-gnu-emacs@gnu.org; Thu, 21 Aug 2014 15:23:11 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:42217) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XKXws-0002uA-1P for bug-gnu-emacs@gnu.org; Thu, 21 Aug 2014 15:23:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XKXwr-0004J8-OB for bug-gnu-emacs@gnu.org; Thu, 21 Aug 2014 15:23:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 21 Aug 2014 19:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18302 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18302-submit@debbugs.gnu.org id=B18302.140864896616503 (code B ref 18302); Thu, 21 Aug 2014 19:23:01 +0000 Original-Received: (at 18302) by debbugs.gnu.org; 21 Aug 2014 19:22:46 +0000 Original-Received: from localhost ([127.0.0.1]:49157 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XKXwb-0004I6-FO for submit@debbugs.gnu.org; Thu, 21 Aug 2014 15:22:45 -0400 Original-Received: from mtaout23.012.net.il ([80.179.55.175]:65086) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XKXwZ-0004Hs-6c for 18302@debbugs.gnu.org; Thu, 21 Aug 2014 15:22:44 -0400 Original-Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0NAO003007RENI00@a-mtaout23.012.net.il> for 18302@debbugs.gnu.org; Thu, 21 Aug 2014 22:22:37 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NAO003V98HOJX70@a-mtaout23.012.net.il>; Thu, 21 Aug 2014 22:22:37 +0300 (IDT) In-reply-to: <53F63C95.6030303@cornell.edu> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:92580 Archived-At: > Date: Thu, 21 Aug 2014 14:38:13 -0400 > From: Ken Brown > CC: chriszheng99@gmail.com, 18302@debbugs.gnu.org > > > I'd urge the Cygwin Emacs maintainers to revert that special case, but > > that's their call. For native Windows builds, I certainly object to > > introducing this deviation. > > The Cygwin situation is not comparable. The headers are installed in > the standard places. But Cygwin provides two versions of xpm.h, one in > /usr/include/X11 and one in /usr/include/noX. The Cygwin w32 build > needs to add -I/usr/include/noX to CPPFLAGS (and -L/usr/lib/noX to > LDFLAGS) in order to pick up the correct version. No, the solution is to use #if defined __CYGWIN__ && !defined HAVE_X_WINDOWS #include #else #include #endif The way we work around the problem now will break if someone installs the standard header files in a place other than /usr/include. And if you disagree, then at least please put the above explanation in configure.ac, so that we won't need to have this discussion a year from now.