From: Eli Zaretskii <eliz@gnu.org>
To: eggert@cs.ucla.edu
Cc: 15880@debbugs.gnu.org
Subject: bug#15880: Compute C declarations for DEFSYMs automatically.
Date: Mon, 05 Jan 2015 21:27:28 +0200 [thread overview]
Message-ID: <83iogl81un.fsf@gnu.org> (raw)
In-Reply-To: <83lhlh83a3.fsf@gnu.org>
> Date: Mon, 05 Jan 2015 20:56:36 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: 15880@debbugs.gnu.org
>
> In file included from dispnew.c:26:0:
> lisp.h:209:23: error: expected ')' before '||' token
> (suppress_checking || (cond) \
> ^
> lisp.h:360:5: note: in expansion of macro 'eassert'
> (eassert (SYMBOLP (a)), \
> ^
> lisp.h:405:21: note: in expansion of macro 'lisp_h_XSYMBOL'
> # define XSYMBOL(a) lisp_h_XSYMBOL (a)
> ^
> lisp.h:612:28: note: in expansion of macro 'XSYMBOL'
> INLINE struct Lisp_Symbol *XSYMBOL (Lisp_Object);
> ^
> lisp.h:360:26: error: expected ')' before ',' token
> (eassert (SYMBOLP (a)), \
> ^
> lisp.h:405:21: note: in expansion of macro 'lisp_h_XSYMBOL'
> # define XSYMBOL(a) lisp_h_XSYMBOL (a)
> ^
> lisp.h:612:28: note: in expansion of macro 'XSYMBOL'
> INLINE struct Lisp_Symbol *XSYMBOL (Lisp_Object);
Is this the right fix?
diff --git a/src/lisp.h b/src/lisp.h
index fc04ab9..d9f43cc 100644
--- a/src/lisp.h
+++ b/src/lisp.h
@@ -609,7 +609,9 @@ INLINE void set_sub_char_table_contents (Lisp_Object, ptrdiff_t,
INLINE bool SUBRP (Lisp_Object);
INLINE bool (SYMBOLP) (Lisp_Object);
INLINE bool (VECTORLIKEP) (Lisp_Object);
+#ifndef XSYMBOL
INLINE struct Lisp_Symbol *XSYMBOL (Lisp_Object);
+#endif
INLINE void *(XUNTAGBASE) (Lisp_Object, int, void *);
INLINE bool WINDOWP (Lisp_Object);
INLINE struct Lisp_Save_Value *XSAVE_VALUE (Lisp_Object);
prev parent reply other threads:[~2015-01-05 19:27 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-13 0:33 bug#15880: Compute C declarations for DEFSYMs automatically Paul Eggert
2013-11-13 3:54 ` Eli Zaretskii
2013-11-13 5:00 ` Paul Eggert
2013-11-13 4:19 ` Stefan Monnier
2013-11-13 5:12 ` Paul Eggert
2013-11-13 13:36 ` Stefan Monnier
2013-11-13 16:25 ` Paul Eggert
2013-11-14 0:26 ` Stefan Monnier
2013-11-14 1:32 ` Paul Eggert
2013-11-14 2:29 ` Stefan Monnier
2013-11-14 4:13 ` Paul Eggert
2013-11-14 5:06 ` Stefan Monnier
2013-11-14 5:26 ` Paul Eggert
2013-11-14 16:28 ` Eli Zaretskii
2013-11-14 20:25 ` Paul Eggert
2013-11-15 7:59 ` Eli Zaretskii
2013-11-15 13:58 ` Stefan Monnier
2013-11-13 16:07 ` Eli Zaretskii
2013-11-13 22:00 ` Stefan Monnier
2013-11-14 3:47 ` Eli Zaretskii
2013-11-14 4:59 ` Stefan Monnier
2013-11-14 16:29 ` Eli Zaretskii
2014-12-20 1:55 ` Paul Eggert
2014-12-23 17:15 ` Stefan Monnier
2014-12-23 23:51 ` Paul Eggert
2015-01-05 16:51 ` Stefan Monnier
2015-01-05 17:25 ` Paul Eggert
2015-01-05 17:55 ` Stefan Monnier
2015-01-05 18:17 ` Paul Eggert
2015-01-05 18:56 ` Eli Zaretskii
2015-01-05 19:24 ` Paul Eggert
2015-01-05 19:48 ` Eli Zaretskii
2015-01-05 22:20 ` Paul Eggert
2015-01-06 3:28 ` Eli Zaretskii
2015-01-07 21:48 ` Glenn Morris
2015-01-08 1:16 ` Paul Eggert
2015-01-08 13:28 ` Eli Zaretskii
2015-01-09 16:33 ` Paul Eggert
2015-01-09 20:06 ` Eli Zaretskii
2015-01-09 20:08 ` Andreas Schwab
2015-01-09 20:50 ` Eli Zaretskii
2015-01-09 21:10 ` Andreas Schwab
2015-01-09 21:48 ` Stefan Monnier
2015-01-10 11:30 ` Eli Zaretskii
2015-01-05 19:27 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83iogl81un.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=15880@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.