all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Samer Masterson <samer@samertm.com>
Cc: stephen_leake@stephe-leake.org, emacs-devel@gnu.org
Subject: Re: [PATCH] Adding testing information to CONTRIBUTE
Date: Sun, 15 Mar 2015 19:39:47 +0200	[thread overview]
Message-ID: <83ioe217oc.fsf@gnu.org> (raw)
In-Reply-To: <1426405787.4214.1@mail.samertm.com>

> Date: Sun, 15 Mar 2015 00:49:47 -0700
> From: Samer Masterson <samer@samertm.com>
> Cc: stephen_leake@stephe-leake.org, emacs-devel@gnu.org
> 
> The patch below adds testing information to Emacs ("make check", the
> "test/automated" directory & make commands)

Thanks.  This looks good to me, but please leave 2 spaces between
sentences, per the US English conventions we use in our documentation
project-wide.
> +2015-03-15 Samer Masterson <samer@samertm.com>
> +
> + * CONTRIBUTE (Test your changes.): Add section.
                                       ^^^^^^^^^^^
Nitpicking: we prefer "New section".

Thanks again for working on tyhis.



  reply	other threads:[~2015-03-15 17:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-05 11:02 Adding testing information to CONTRIBUTE Samer Masterson
2015-03-05 14:14 ` Samer Masterson
2015-03-05 16:47   ` Eli Zaretskii
2015-03-05 19:31     ` Samer Masterson
2015-03-15  7:49       ` [PATCH] " Samer Masterson
2015-03-15 17:39         ` Eli Zaretskii [this message]
2015-03-05 16:41 ` Eli Zaretskii
2015-03-05 19:25   ` Samer Masterson
  -- strict thread matches above, loose matches on Subject: below --
2015-03-15 17:47 [PATCH] " Samer Masterson
2015-03-21 10:10 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83ioe217oc.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=samer@samertm.com \
    --cc=stephen_leake@stephe-leake.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.