From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Emacs 24.5 second release candidate Date: Fri, 03 Apr 2015 15:00:55 +0300 Message-ID: <83ioddpgjs.fsf@gnu.org> References: <87619fvb9s.fsf@blueberry.home> <87384juhme.fsf@blueberry.home> <87zj6qtzch.fsf@blueberry.home> <20150402140228.GB23848@acm.fritz.box> <838uear1xa.fsf@gnu.org> <20150402161256.GC23848@acm.fritz.box> <834moyqwb9.fsf@gnu.org> <20150403110615.GA2867@acm.fritz.box> <83pp7lphza.fsf@gnu.org> <20150403115142.GB2867@acm.fritz.box> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1428062483 27123 80.91.229.3 (3 Apr 2015 12:01:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 3 Apr 2015 12:01:23 +0000 (UTC) Cc: rgm@gnu.org, nicolas@petton.fr, monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Apr 03 14:01:18 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Ye0Hl-0000PU-Jb for ged-emacs-devel@m.gmane.org; Fri, 03 Apr 2015 14:01:17 +0200 Original-Received: from localhost ([::1]:33923 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ye0Hl-0000pB-4g for ged-emacs-devel@m.gmane.org; Fri, 03 Apr 2015 08:01:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37103) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ye0HZ-0000p6-8y for emacs-devel@gnu.org; Fri, 03 Apr 2015 08:01:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ye0HV-0003yo-95 for emacs-devel@gnu.org; Fri, 03 Apr 2015 08:01:05 -0400 Original-Received: from mtaout28.012.net.il ([80.179.55.184]:41915) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ye0HV-0003yN-1A; Fri, 03 Apr 2015 08:01:01 -0400 Original-Received: from conversion-daemon.mtaout28.012.net.il by mtaout28.012.net.il (HyperSendmail v2007.08) id <0NM800600BPZ6800@mtaout28.012.net.il>; Fri, 03 Apr 2015 14:59:41 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout28.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NM800KT0BZHF4A0@mtaout28.012.net.il>; Fri, 03 Apr 2015 14:59:41 +0300 (IDT) In-reply-to: <20150403115142.GB2867@acm.fritz.box> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 80.179.55.184 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:184835 Archived-At: > Date: Fri, 3 Apr 2015 11:51:42 +0000 > Cc: rgm@gnu.org, nicolas@petton.fr, monnier@iro.umontreal.ca, > emacs-devel@gnu.org > From: Alan Mackenzie > > > How about simply reverting d69e9f1c24f37f36af33b0468c5a4e100dbb09b6? > > I'd like to avoid holding 24.5, unless reverting that commit would > > result in some very bad behavior in frequent use cases. > > I think this would be for the best. It's just the bug it "fixed" will > remain apparent. Could you perhaps give me a tip as to how best to > revert a commit with git? Like this: $ git revert d69e9f1c24f37f36af33b0468c5a4e100dbb09b6 This applies the reverse changes, and commits them. IOW, the original commit is not removed; instead, a new commit is added that undoes the effects of that old commit. Then "git show" to see what you are about to push, and then "git push". Be sure to do this in the emacs-24 branch, i.e. "git checkout emacs-24" before doing the above. Thanks.