From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Patch for warnings in 64bit Windows builds Date: Tue, 28 Jul 2015 16:40:14 +0300 Message-ID: <83io94xuwx.fsf@gnu.org> References: Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1438090869 18290 80.91.229.3 (28 Jul 2015 13:41:09 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 28 Jul 2015 13:41:09 +0000 (UTC) Cc: emacs-devel@gnu.org To: Andy Moreton Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 28 15:40:57 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZK57p-0006Tx-HC for ged-emacs-devel@m.gmane.org; Tue, 28 Jul 2015 15:40:57 +0200 Original-Received: from localhost ([::1]:58813 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZK57o-0002Qb-NN for ged-emacs-devel@m.gmane.org; Tue, 28 Jul 2015 09:40:56 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45968) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZK57O-0002Pl-85 for emacs-devel@gnu.org; Tue, 28 Jul 2015 09:40:34 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZK57J-0007FE-3u for emacs-devel@gnu.org; Tue, 28 Jul 2015 09:40:30 -0400 Original-Received: from mtaout27.012.net.il ([80.179.55.183]:49275) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZK57I-0007EC-Rk for emacs-devel@gnu.org; Tue, 28 Jul 2015 09:40:25 -0400 Original-Received: from conversion-daemon.mtaout27.012.net.il by mtaout27.012.net.il (HyperSendmail v2007.08) id <0NS700F009IAUQ00@mtaout27.012.net.il> for emacs-devel@gnu.org; Tue, 28 Jul 2015 16:37:55 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout27.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NS700DWC9V64530@mtaout27.012.net.il>; Tue, 28 Jul 2015 16:37:55 +0300 (IDT) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 80.179.55.183 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:188127 Archived-At: > From: Andy Moreton > Date: Tue, 28 Jul 2015 12:57:42 +0100 > > The 64bit Windows builds have shown a few warnings for some time: > > ../../src/w32proc.c: In function 'w32_compare_strings': > ../../src/w32proc.c:3526:20: warning: assignment from incompatible pointer type [-Wincompatible-pointer-types] > pCompareStringW = GetProcAddress (LoadLibrary ("Unicows.dll"), > ^ > ../../src/w32fns.c: In function 'Ffile_system_info': > ../../src/w32fns.c:7827:9: warning: initialization from incompatible pointer type [-Wincompatible-pointer-types] > = GetProcAddress (hKernel, "GetDiskFreeSpaceExW"); > ^ > ../../src/w32fns.c:7830:9: warning: initialization from incompatible pointer type [-Wincompatible-pointer-types] > = GetProcAddress (hKernel, "GetDiskFreeSpaceExA"); > ^ > The following patch builds cleanly on: > - 32bit mingw > - 32bit mingw --with-wide-int > - 64bit mingw64 Thanks, pushed. > I don't have copyright paperwork on file, so please let me know if that > is required. Not needed, but you are encouraged to start the paperwork rolling, so it will be ready for your next contribution.