From: Eli Zaretskii <eliz@gnu.org>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] emacs-25 504696d: Etags: yet another improvement in Ruby tags
Date: Thu, 04 Feb 2016 19:28:46 +0200 [thread overview]
Message-ID: <83io24wfjl.fsf@gnu.org> (raw)
In-Reply-To: <56B31B99.6010400@yandex.ru> (message from Dmitry Gutov on Thu, 4 Feb 2016 12:36:25 +0300)
> Cc: emacs-devel@gnu.org
> From: Dmitry Gutov <dgutov@yandex.ru>
> Date: Thu, 4 Feb 2016 12:36:25 +0300
>
> >>> + alias_method :qux, :tee, attr_accessor :bogus
> >>
> >> This one is a bit weird as well:
> >>
> >> - An alias_method call with three arguments will raise an ArgumentError.
> >
> > It's there to test the algorithm, which should not tag the bogus
> > accessor.
>
> Why is it bogus, though?
Because its syntax is invalid.
> For instance, these examples are syntactically valid and would result in
> the generation of the method 'foo':
>
> class C
> puts(attr_accessor :foo)
> end
>
> class C
> 1 + 2; attr_reader :bar
> end
>
> We don't really need to support them, but actively fighting against them
> seems odd.
We don't fight them. The above 2 examples work as expected, please
try them (if you didn't already).
The example which is in the test file specifically tests the handling
of stuff that follows a comma after alias_method, since that requires
some logic I wanted to be sure I got right.
> Point is, the example code is syntactically invalid. etags doesn't need
> to handle that kind of code at all, right?
No, but I wanted to be sure the invalid code doesn't adversely affect
valid code further in the file.
> It would be better to get a syntactically-valid example, if we an
> find one.
If you can, by all means. As I don't speak Ruby, I just went with the
simplest one I could throw together.
next prev parent reply other threads:[~2016-02-04 17:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160203162536.2954.45438@vcs.savannah.gnu.org>
[not found] ` <E1aR0FM-0000mG-Up@vcs.savannah.gnu.org>
2016-02-03 23:46 ` [Emacs-diffs] emacs-25 504696d: Etags: yet another improvement in Ruby tags Dmitry Gutov
2016-02-04 3:48 ` Eli Zaretskii
2016-02-04 9:36 ` Dmitry Gutov
2016-02-04 17:28 ` Eli Zaretskii [this message]
2016-02-05 5:26 ` Dmitry Gutov
2016-02-05 5:29 ` Dmitry Gutov
2016-02-05 9:14 ` Eli Zaretskii
2016-02-05 10:11 ` Dmitry Gutov
2016-02-05 11:15 ` Eli Zaretskii
2016-02-05 11:26 ` Eli Zaretskii
2016-02-05 12:15 ` Dmitry Gutov
2016-02-05 14:34 ` Eli Zaretskii
2016-02-06 9:09 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83io24wfjl.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.