From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#23075: 24.5; vc-git-command should use coding-system-for-read Date: Sat, 02 Apr 2016 12:58:33 +0300 Message-ID: <83io00s56e.fsf@gnu.org> References: <56EFD97C.3080805@gmail.com> <83wpov6c35.fsf@gnu.org> <87d1qng4aj.fsf@wanadoo.es> <87egb3r9wc.fsf@linux-m68k.org> <83k2kv66bj.fsf@gnu.org> <56F04154.9010405@gmail.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1459591226 3719 80.91.229.3 (2 Apr 2016 10:00:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 2 Apr 2016 10:00:26 +0000 (UTC) Cc: 23075-done@debbugs.gnu.org To: Nikolay Kudryavtsev Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Apr 02 12:00:17 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1amILm-0006zO-CH for geb-bug-gnu-emacs@m.gmane.org; Sat, 02 Apr 2016 12:00:14 +0200 Original-Received: from localhost ([::1]:48771 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1amILl-0000uA-Fy for geb-bug-gnu-emacs@m.gmane.org; Sat, 02 Apr 2016 06:00:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50339) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1amILe-0000pB-HT for bug-gnu-emacs@gnu.org; Sat, 02 Apr 2016 06:00:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1amILb-0007k9-D7 for bug-gnu-emacs@gnu.org; Sat, 02 Apr 2016 06:00:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:50668) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1amILb-0007jt-B5 for bug-gnu-emacs@gnu.org; Sat, 02 Apr 2016 06:00:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1amILb-00074q-5p for bug-gnu-emacs@gnu.org; Sat, 02 Apr 2016 06:00:03 -0400 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 Apr 2016 10:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 23075 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 23075@debbugs.gnu.org, eliz@gnu.org, nikolay.kudryavtsev@gmail.com Original-Received: via spool by 23075-done@debbugs.gnu.org id=D23075.145959115626952 (code D ref 23075); Sat, 02 Apr 2016 10:00:02 +0000 Original-Received: (at 23075-done) by debbugs.gnu.org; 2 Apr 2016 09:59:16 +0000 Original-Received: from localhost ([127.0.0.1]:47794 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1amIKq-00070c-6h for submit@debbugs.gnu.org; Sat, 02 Apr 2016 05:59:16 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:59227) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1amIKn-0006za-QA for 23075-done@debbugs.gnu.org; Sat, 02 Apr 2016 05:59:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1amIKf-0007bb-J7 for 23075-done@debbugs.gnu.org; Sat, 02 Apr 2016 05:59:08 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:36898) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1amIKf-0007bR-Fc; Sat, 02 Apr 2016 05:59:05 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4603 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1amIKf-0003u3-0e; Sat, 02 Apr 2016 05:59:05 -0400 In-reply-to: <56F04154.9010405@gmail.com> (message from Nikolay Kudryavtsev on Mon, 21 Mar 2016 21:45:40 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:115863 Archived-At: > From: Nikolay Kudryavtsev > Cc: 23075@debbugs.gnu.org > Date: Mon, 21 Mar 2016 21:45:40 +0300 > > 1. Clone https://github.com/sg2002/vc-git-bugs > 2. Open 1251.txt in windows1251 encoding. Do some changes in it. > 3. vc-diff. This would give you diff with broken encoding. > 4. Evaluate vc-git-command from fix.el in the repo. > 5. vc-diff again, it would give you the correct encoding as long as the > file itself opened correctly. > > Yes, there is some code that specifies encoding in vc already. See the > first large comment in vc-diff-internal. > > This issue is not platform specific, unlike 23076. Thanks, this should now be fixed by commit 17b5152. I'm closing this bug report. Feel free to reopen if any issues remain unresolved.