From: Eli Zaretskii <eliz@gnu.org>
To: Nikolay Kudryavtsev <nikolay.kudryavtsev@gmail.com>
Cc: 23075-done@debbugs.gnu.org
Subject: bug#23075: 24.5; vc-git-command should use coding-system-for-read
Date: Sat, 02 Apr 2016 12:58:33 +0300 [thread overview]
Message-ID: <83io00s56e.fsf@gnu.org> (raw)
In-Reply-To: <56F04154.9010405@gmail.com> (message from Nikolay Kudryavtsev on Mon, 21 Mar 2016 21:45:40 +0300)
> From: Nikolay Kudryavtsev <nikolay.kudryavtsev@gmail.com>
> Cc: 23075@debbugs.gnu.org
> Date: Mon, 21 Mar 2016 21:45:40 +0300
>
> 1. Clone https://github.com/sg2002/vc-git-bugs
> 2. Open 1251.txt in windows1251 encoding. Do some changes in it.
> 3. vc-diff. This would give you diff with broken encoding.
> 4. Evaluate vc-git-command from fix.el in the repo.
> 5. vc-diff again, it would give you the correct encoding as long as the
> file itself opened correctly.
>
> Yes, there is some code that specifies encoding in vc already. See the
> first large comment in vc-diff-internal.
>
> This issue is not platform specific, unlike 23076.
Thanks, this should now be fixed by commit 17b5152.
I'm closing this bug report. Feel free to reopen if any issues remain
unresolved.
prev parent reply other threads:[~2016-04-02 9:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-21 11:22 bug#23075: 24.5; vc-git-command should use coding-system-for-read Nikolay Kudryavtsev
2016-03-21 16:16 ` Eli Zaretskii
2016-03-21 16:54 ` Óscar Fuentes
2016-03-21 17:21 ` Eli Zaretskii
2016-03-21 17:57 ` Andreas Schwab
2016-03-21 18:05 ` Óscar Fuentes
2016-03-21 18:22 ` Eli Zaretskii
2016-03-21 19:38 ` Óscar Fuentes
2016-04-02 10:02 ` Eli Zaretskii
2016-03-21 18:20 ` Eli Zaretskii
2016-03-21 18:45 ` Nikolay Kudryavtsev
2016-03-21 19:17 ` Eli Zaretskii
2016-03-21 19:35 ` Nikolay Kudryavtsev
2016-04-02 9:58 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83io00s56e.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=23075-done@debbugs.gnu.org \
--cc=nikolay.kudryavtsev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.