From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: Compilation warnings in mouse.el
Date: Wed, 13 Jul 2016 17:31:34 +0300 [thread overview]
Message-ID: <83inw9a9tl.fsf@gnu.org> (raw)
In-Reply-To: <jwvbn221nab.fsf-monnier+gmane.emacs.devel@gnu.org> (message from Stefan Monnier on Tue, 12 Jul 2016 18:58:12 -0400)
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Date: Tue, 12 Jul 2016 18:58:12 -0400
>
> EZ> Unlike Stefan, I think we should add :group to every defcustom. Having
> EZ> them mysteriously missing from some of them is a time bomb:
>
> The way I see it, defcustoms should pretty much never have :group, and
> the group to which they belong is simply determined by the file in which
> they occur.
But as long as such a system isn't installed, we shouldn't behave as
if it were. (And what you propose is not without downsides, I think.)
> EZ> remove or add
> EZ> enough defcustoms in the same file, and you have a bug.
>
> I don't see how removing/adding defcustoms in the same file
> would introduce problems.
We just saw such a problem, no?
> PS: Incidentally, we have two definitions of the `mouse' group
> in cus-edit.el:
Thanks. Bonus points for fixing that.
next prev parent reply other threads:[~2016-07-13 14:31 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-11 14:23 Compilation warnings in mouse.el Eli Zaretskii
2016-07-11 21:55 ` Stephen Berman
2016-07-12 5:04 ` Eli Zaretskii
2016-07-12 8:45 ` Stephen Berman
2016-07-12 22:40 ` John Wiegley
2016-07-12 22:58 ` Stefan Monnier
2016-07-13 9:28 ` Joost Kremers
2016-07-13 12:45 ` Stefan Monnier
2016-07-13 14:08 ` Drew Adams
2016-07-13 14:31 ` Eli Zaretskii [this message]
2016-07-13 15:12 ` Stefan Monnier
2016-07-13 15:22 ` Drew Adams
2016-07-13 15:37 ` Stefan Monnier
2016-07-13 16:07 ` Drew Adams
2016-07-13 15:36 ` Eli Zaretskii
2016-07-13 15:42 ` Stefan Monnier
2016-07-13 16:07 ` Drew Adams
2016-07-13 16:13 ` Eli Zaretskii
2016-07-13 16:42 ` Stefan Monnier
2016-07-12 22:56 ` Dmitry Gutov
2016-07-13 14:30 ` Eli Zaretskii
2016-07-13 14:41 ` Dmitry Gutov
[not found] <<8360scdzik.fsf@gnu.org>
[not found] ` <<87zipnzvo4.fsf@gmx.net>
[not found] ` <<8337nfcupy.fsf@gnu.org>
2016-07-12 14:04 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83inw9a9tl.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.